Include index signatures for tagged primitives in keyof #45773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
ahejlsberg
requested review from
andrewbranch,
DanielRosenwasser and
weswigham
weswigham
approved these changes
Sep 7, 2021
|
@DanielRosenwasser We may want to consider pulling this into a 4.4 point release. |
|
@typescript-bot test this Even if this comes back clean, I don't know if I'd feel comfortable with cherry-picking to release-4.4. |
|
Heya @DanielRosenwasser, I've started to run the parallelized community code test suite on this PR at 1774fcf. You can monitor the build here. |
|
Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at 1774fcf. You can monitor the build here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45772.