Skip to content

Revert "fix(45501): VS Code removes spaces between empty object literals even if insertSpaceAfterOpeningAndBeforeClosingEmptyBraces is true" #45682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2021

Conversation

andrewbranch
Copy link
Member

Reverts #45514

Decided we need two settings for this if we’re going to fix it, but also want to gauge demand for #45501 before doing anything.

… with enabled insertSpaceAfterOpeningAndBeforeClosingEmptyBraces (#45514)"

This reverts commit 076f22b.
@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 1, 2021
@a-tarasyuk
Copy link
Contributor

My fault 😕. What should be the name of the option for this case?

@andrewbranch
Copy link
Member Author

Not your fault! Part of the problem is this option was just poorly named. We would probably want to deprecate it in favor of two new settings, probably something like insertSpaceInEmptyObjects and insertSpaceInEmptyBlocks.

@andrewbranch
Copy link
Member Author

@mjbvz do you want us to pick this into 4.4.3?

@mjbvz
Copy link
Contributor

mjbvz commented Sep 1, 2021

Thanks @andrewbranch! Did this make it into 4.4? If so, yes I think we should included the revert in 4.4.3

@andrewbranch
Copy link
Member Author

I’m sorry, I was confused, the change was not in 4.4. No cherry-pick needed then 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants