feat(45295): Consider adding setting that only shows inlay hint parameter names for simple literals (string, number, bool) #45457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
Collaborator
|
The TypeScript team hasn't accepted the linked issue #45295. If you can get it accepted, this PR will have a better chance of being reviewed. |
Member
|
After discussing this with @RyanCavanaugh, our feeling was that the behavior of "simple literals" is actually how it ought to behave for "literals". We don't feel like most people's notion of literals includes object literals and function expressions. I'm not sure whether others have the same feeling here. |
Contributor
Author
|
/cc @mjbvz |
Contributor
Author
|
@DanielRosenwasser Thanks for the feedback. Do I need to delete this PR? |
Member
|
Yes, I've opened up #45557. |
Contributor
Author
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45295