Fix(DeprecationWarning): Work around in testRunner

[Luxcium]

DeprecationWarning: "Runner(suite: Suite, delay: boolean)" is deprecated. Use "Runner(suite: Suite, {delay: boolean})" instead.
fixes #44922
@sandersn

Signed-off-by: Benjamin Vincent (Luxcium) luxcium@neb401.com

Please verify that:

• There is an associated issue in the Backlog milestone (required)
• Code is up-to-date with the main branch
• You've successfully run gulp runtests locally
• You've successfully run gulp tests & gulp runtests-parallel --light=false locally
• There are new or updated unit tests validating the change
• fixes DeprecationWarning: in testRunner  #44922

[Luxcium]

Temporary work around because Mocha Type Definition is not up to date

• Type Definition (8.2) expects: constructor(suite: Suite, delay: boolean);
• Mocha (9.0.2) expects: constructor(suite, opts)

[JoshuaKGoldberg]

FWIW I ran npm i @types/mocha@latest locally and it was updated to a version that has RunnerOptions | boolean. So this workaround shouldn't be necessary anymore @Luxcium 👍

[sandersn]

Thanks, I'll close this then.

[Luxcium]

@sandersn

• There is NO associated issue in the Backlog milestone (required)...
• I do not think it is expected to have test suit for the test suit runner...

[sandersn]

How hard would it be to update mocha's types to 9.0? There are almost 3,000 lines of types, so it might be prohibitively difficult. On the other hand, maybe { delay: boolean } is in 8.* too?

[Luxcium]

I have annotated both Mocha constructor and the type library in my review of my PR... Oups ok I should probably consider looking in the Mocha 8. to see if it could be compatible and updated in the type 8.x

[Luxcium]

In Mocha the constructor was updated here on line 127/129

From function Runner(suite, delay) to function Runner(suite, opts)
which was around version 7.1.0

Therefore as @sandersn suggested this is something that should be first fixed in the type definition... and then this issue could be resolved without using a « workaround »

The @type/mocha related to this issue is located here on line 1403

― Originally posted by @Luxcium in #44922 (comment)

― and posted in (DefinitelyTyped/DefinitelyTyped#54416)

[sandersn]

I think I'd prefer // @ts-expect-error instead of a cast, because we'll be forced to fix it when mocha@9 gets types.

The explanation is good though.