Skip to content

Fix(DeprecationWarning): Work around in testRunner #44923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Fix(DeprecationWarning): Work around in testRunner #44923

wants to merge 3 commits into from

Conversation

Luxcium
Copy link

@Luxcium Luxcium commented Jul 7, 2021 •
edited
Loading

DeprecationWarning: "Runner(suite: Suite, delay: boolean)" is deprecated. Use "Runner(suite: Suite, {delay: boolean})" instead.

Please verify that:

  • There is an associated issue in the Backlog milestone (required)
  • Code is up-to-date with the main branch
  • You've successfully run gulp runtests locally
  • There are new or updated unit tests validating the change

Fixes #44922

@Luxcium
Fix(DeprecationWarning): Work around in testRunner
7dafcc5 
DeprecationWarning: "Runner(suite: Suite, delay: boolean)" is deprecated. Use "Runner(suite: Suite, {delay: boolean})" instead.
fixes [#44922](#44922)
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 7, 2021
@Luxcium Luxcium mentioned this pull request Jul 7, 2021
Closed
5 tasks
Luxcium
Luxcium commented Jul 7, 2021
View reviewed changes
src/testRunner/parallel/worker.ts
@@ -209,7 +209,12 @@ namespace Harness.Parallel.Worker {
const errors: ErrorInfo[] = [];
const passes: TestInfo[] = [];
const start = +new Date();
const runner = new Mocha.Runner(suite, /*delay*/ false);
/* DeprecationWarning: "Runner(suite: Suite, delay: boolean)" is deprecated. Use "Runner(suite: Suite, {delay: boolean})" instead.*/
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary work around because Mocha Type Definition is not up to date

oscard0m and others added 2 commits July 7, 2021 12:52
@oscard0m
ci(workflows): bump 'setup-node' to v2 and use 'cache' option
9944188
@Luxcium
Merge pull request #44924 from oscard0m/add-cache-to-node-workflows
ad39e95 
ci(workflows): bump 'setup-node' to v2 and use 'cache' option
Based on an open commit that may change by @oscard0m: #44924
- Add cache to workflows using actions/setup-node
- Bump actions/setup-node to v2 to give support to this cache option
@Luxcium
Copy link
Author

Luxcium commented Jul 7, 2021

will resubmit

@Luxcium Luxcium closed this Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DeprecationWarning: in testRunner
3 participants
@Luxcium @typescript-bot @oscard0m