Wire up 'writing' parameter through protected derived class detection #43455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
sandersn
requested changes
Apr 19, 2021
| // These should error | ||
| b.q = 0; | ||
| ~ | ||
| !!! error TS2446: Property 'q' is protected and only accessible through an instance of class 'A'. This is an instance of class 'B'. |
There was a problem hiding this comment.
q and u are accessors on B, not A. This error message is wrong. Is that expected? (From the bug, it seems like it might be outside the scope of this fix.)
There was a problem hiding this comment.
Yeah, I'll file a new issue
| protected get u() { return 0; } | ||
| protected set u(v: number) { } | ||
|
|
||
| foo(this: A, a: A, b: B) { |
There was a problem hiding this comment.
highly recommend switching from foo/bar/baz to donkey/diddy/cranky
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43443