Skip to content

Improvements to dts emit for tsbuildinfo #43205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 12, 2021
Merged

Improvements to dts emit for tsbuildinfo #43205

merged 4 commits into from
Mar 12, 2021

Conversation

sheetalkamat
Copy link
Member

  1. Do not emit source maps when generating dts file
  2. Json files from project reference should be able to do dts emit
  3. Default if for any reason signature calculation fails should be source file version and exported modules from the file (just like what we do for d.ts file)

Copy link
Member

@weswigham weswigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't use the maps for LS results while project results are still pending, right?

@sheetalkamat
Copy link
Member Author

This is strictly for builder which forces dts emit .. project if at all will always use declaration maps from disk and getting compile on save result is same as emit ( without forcing dts emit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants