Unnecessary elaboration about not being assignable to type parameters #42952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonhue
commented
Feb 25, 2021
Comment on lines
46
to
-49
| Type 'T' is not assignable to type 'T'. Two different types with this name exist, but they are unrelated. | ||
| 'T' could be instantiated with an arbitrary type which could be unrelated to 'T'. | ||
| Type 'Base' is not assignable to type 'T'. | ||
| 'T' could be instantiated with an arbitrary type which could be unrelated to 'Base'. |
There was a problem hiding this comment.
One thing which I'm not 100% certain about based on the original issue, is whether we want to continue elaborating if the target and source type are the same. Like in this case where both are T. What do you think?
Theoretically, we could also be even more conservative by only stopping elaboration when the target is some type parameter (e.g. T) and the source is a union of that type parameter and something else (e.g. T | SomeOtherType).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42849