Skip to content

fix(42765): require should not work in ts files #42792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

Zzzen
Copy link
Contributor

@Zzzen Zzzen commented Feb 13, 2021

Fixes #42765

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Feb 13, 2021
>exports.equal() : void
>exports.equal : (actual: any, expected: any, message?: string | Error) => void
>exports : typeof import("tests/cases/compiler/app")
>equal : (actual: any, expected: any, message?: string | Error) => void
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reproduction: equal should be any

Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, simple repro of this tricky bug!

@sandersn sandersn merged commit 3d1c6e8 into microsoft:master Mar 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

In JS, exporting a global require from TS incorrectly treats it like an export alias
3 participants