Error message improvements for unions with identical discriminants #42598
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,130 @@ | ||
| tests/cases/compiler/contextualTypeShouldBeLiteral.ts(40,5): error TS2345: Argument of type '{ type2: "y"; value: "done"; method(): void; }' is not assignable to parameter of type 'X2 | Y2'. | ||
| Object literal may only specify known properties, but 'type2' does not exist in type 'X2'. Did you mean to write 'type1'? | ||
|
|
||
|
|
||
| ==== tests/cases/compiler/contextualTypeShouldBeLiteral.ts (1 errors) ==== | ||
| interface X { | ||
| type: 'x'; | ||
| value: string; | ||
| method(): void; | ||
| } | ||
|
|
||
| interface Y { | ||
| type: 'y'; | ||
| value: 'none' | 'done'; | ||
| method(): void; | ||
| } | ||
|
|
||
| function foo(bar: X | Y) { } | ||
|
|
||
| foo({ | ||
| type: 'y', | ||
| value: 'done', | ||
| method() { | ||
| this; | ||
| this.type; | ||
| this.value; | ||
| } | ||
| }); | ||
|
|
||
| interface X2 { | ||
| type1: 'x'; | ||
| value: string; | ||
| method(): void; | ||
| } | ||
|
|
||
| interface Y2 { | ||
| type2: 'y'; | ||
| value: 'none' | 'done'; | ||
| method(): void; | ||
| } | ||
|
|
||
| function foo2(bar: X2 | Y2) { } | ||
|
|
||
| foo2({ | ||
| type2: 'y', | ||
| ~~~~~~~~~~ | ||
| !!! error TS2345: Argument of type '{ type2: "y"; value: "done"; method(): void; }' is not assignable to parameter of type 'X2 | Y2'. | ||
| !!! error TS2345: Object literal may only specify known properties, but 'type2' does not exist in type 'X2'. Did you mean to write 'type1'? | ||
| value: 'done', | ||
| method() { | ||
| this; | ||
| this.value; | ||
| } | ||
| }); | ||
|
|
||
| interface X3 { | ||
| type: 'x'; | ||
| value: 1 | 2 | 3; | ||
| xtra: number; | ||
| } | ||
|
|
||
| interface Y3 { | ||
| type: 'y'; | ||
| value: 11 | 12 | 13; | ||
| ytra: number; | ||
| } | ||
|
|
||
| let xy: X3 | Y3 = { | ||
| type: 'y', | ||
| value: 11, | ||
| ytra: 12 | ||
| }; | ||
|
|
||
| xy; | ||
|
|
||
|
|
||
| interface LikeA { | ||
| x: 'x'; | ||
| y: 'y'; | ||
| value: string; | ||
| method(): void; | ||
| } | ||
|
|
||
| interface LikeB { | ||
| x: 'xx'; | ||
| y: 'yy'; | ||
| value: number; | ||
| method(): void; | ||
| } | ||
|
|
||
| let xyz: LikeA | LikeB = { | ||
| x: 'x', | ||
| y: 'y', | ||
| value: "foo", | ||
| method() { | ||
| this; | ||
| this.x; | ||
| this.y; | ||
| this.value; | ||
| } | ||
| }; | ||
|
|
||
| xyz; | ||
|
|
||
| // Repro from #29168 | ||
|
|
||
| interface TestObject { | ||
| type?: 'object'; | ||
| items: { | ||
| [k: string]: TestGeneric; | ||
| }; | ||
| } | ||
|
|
||
| interface TestString { | ||
| type: 'string'; | ||
| } | ||
|
|
||
| type TestGeneric = (TestString | TestObject) & { [k: string]: any; }; | ||
|
|
||
| const test: TestGeneric = { | ||
| items: { | ||
| hello: { type: 'string' }, | ||
| world: { | ||
| items: { | ||
| nested: { type: 'string' } | ||
| } | ||
| } | ||
| } | ||
| }; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new error - I'd argue this is actually a regression.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, isn’t this perfectly assignable to
Y2?