Add a test for JSX namespace lookup with jsx: preserve, jsxImportSource
#41676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Andarist
commented
Nov 24, 2020
| @@ -1,5 +1,5 @@ | |||
| // @strict: true | |||
| // @jsx: react-jsx | |||
| // @jsx: preserve,react-jsx | |||
There was a problem hiding this comment.
I have no idea what's expected result of @jsx: react + @jsxImportSource: @emotion/react though. It seems like it could be considered an invalid combination?
There was a problem hiding this comment.
We could issue an error in program.ts (within verifyCompilerOptions) - that's probably fine.
|
Note: when I merged from master, I did so when master was broken from some other very-old PRs I recently merged, so this PR now includes a couple of unrelated baseline updates. |
|
@sandersn thanks for taking care of this! Was planning to do it later today but u beat me to it 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a simple follow-up to #41476 which aims to add a regression test that seems to be sufficiently different from the one provided in that PR. At the time I have been providing that former PR I have thought that
jsx: react-jsx,react-jsxdevis a requirement forjsxImportSourceto work but apparently it isn't:TypeScript/src/compiler/utilities.ts
Line 6039 in d070acf
I'm glad that it actually works with
jsx: preserveso I thought it might be a good idea to provide a test for this