Remove special `any` assignability for numeric index signatures by DanielRosenwasser · Pull Request #41660 · microsoft/TypeScript

DanielRosenwasser · 2020-11-23T23:44:38Z

Experiment to fix #18757

…'any'.

DanielRosenwasser · 2020-11-23T23:44:58Z

@typescript-bot pack this
@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this

DanielRosenwasser · 2020-11-24T00:51:43Z

A couple of breaks:

DanielRosenwasser · 2020-11-24T00:52:48Z

tests/baselines/reference/subclassThisTypeAssignable.errors.txt

    interface Lifecycle<Attrs, State> {
    	oninit?(vnode: Vnode<Attrs, State>): number;
+    	                            ~~~~~
+!!! error TS2344: Type 'State' does not satisfy the constraint 'Lifecycle<Attrs, State>'.


This was a bug. State needs the constraint Lifecycle<Attrs, State>.

DanielRosenwasser · 2020-11-24T00:58:10Z

tests/baselines/reference/subclassThisTypeAssignable.errors.txt

    class C implements ClassComponent<MyAttrs> {
    	view(v: Vnode<MyAttrs>) { return 0; }
+    	~~~~
+!!! error TS2416: Property 'view' in type 'C' is not assignable to the same property in base type 'ClassComponent<MyAttrs>'.


This basically comes down to the following break:

interface Indexable { [x: number]: any; } class C implements Indexable { }

In earlier versions, implementing C without re-declaring the index signature was valid.

I would argue that this behavior is still surprising or incorrect for string index signatures, but that might be very breaky.

DanielRosenwasser · 2020-11-24T00:58:33Z

~~I still need to add tests for the original use-case.~~
Done.

…ityForNumericIndexSignature

DanielRosenwasser · 2021-02-17T00:40:29Z

Updates:

The original use-case is now in our test suite. A function will not be assignable to an ArrayLike<any>.
I added a modified version of subclassThisTypeAssignable to the test suite that has no errors at all. It avoids weird circularity errors, appropriately adds constraints where needed, and adds the index signature that this PR now requires.

DanielRosenwasser · 2021-02-17T00:42:36Z

@typescript-bot pack this
@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this faster

typescript-bot · 2021-02-17T00:42:39Z

Heya @DanielRosenwasser, I've started to run the extended test suite on this PR at 7dd8232. You can monitor the build here.

typescript-bot · 2021-02-17T00:42:39Z

Heya @DanielRosenwasser, I've started to run the parallelized Definitely Typed test suite on this PR at 7dd8232. You can monitor the build here.

typescript-bot · 2021-02-17T00:42:39Z

Heya @DanielRosenwasser, I've started to run the perf test suite on this PR at 7dd8232. You can monitor the build here.

Update: The results are in!

typescript-bot · 2021-02-17T00:42:39Z

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 7dd8232. You can monitor the build here.

typescript-bot · 2021-02-17T00:42:39Z

Heya @DanielRosenwasser, I've started to run the parallelized community code test suite on this PR at 7dd8232. You can monitor the build here.

typescript-bot · 2021-02-17T00:42:39Z

Heya @DanielRosenwasser, I've started to run the abridged perf test suite on this PR at 7dd8232. You can monitor the build here.

Update: The results are in!

typescript-bot · 2021-02-17T01:01:03Z

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/96104/artifacts?artifactName=tgz&fileId=725D486DC8DC05AB721965911838904BA35D7E081E334972C22EB8368E077D2802&fileName=/typescript-4.3.0-insiders.20210217.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@4.3.0-pr-41660-19".;

typescript-bot · 2021-02-17T01:39:35Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..41660

_Metric	_master	₄₁₆₆₀	_Delta	_Best	_Worst
_{Angular - node (v10.16.3, x64)}
_{Memory used}	_{345,850k (± 0.02%)}	_{345,941k (± 0.03%)}	_{+91k (+ 0.03%)}	_345,734k	_346,138k
_{Parse Time}	_{1.92s (± 0.39%)}	_{1.92s (± 0.43%)}	_{-0.00s (- 0.10%)}	_1.90s	_1.93s
_{Bind Time}	_{0.82s (± 0.45%)}	_{0.82s (± 0.49%)}	_{-0.01s (- 0.73%)}	_0.81s	_0.83s
_{Check Time}	_{4.95s (± 0.36%)}	_{4.95s (± 0.46%)}	_{-0.00s (- 0.08%)}	_4.90s	_5.01s
_{Emit Time}	_{5.25s (± 0.64%)}	_{5.24s (± 0.57%)}	_{-0.00s (- 0.10%)}	_5.17s	_5.30s
_{Total Time}	_{12.94s (± 0.39%)}	_{12.93s (± 0.35%)}	_{-0.02s (- 0.13%)}	_12.80s	_13.01s
_{Compiler-Unions - node (v10.16.3, x64)}
_{Memory used}	_{214,444k (± 0.06%)}	_{214,460k (± 0.06%)}	_{+16k (+ 0.01%)}	_214,058k	_214,651k
_{Parse Time}	_{0.78s (± 0.88%)}	_{0.78s (± 0.61%)}	_{+0.00s (+ 0.13%)}	_0.77s	_0.79s
_{Bind Time}	_{0.49s (± 1.54%)}	_{0.49s (± 1.21%)}	_{+0.00s (+ 0.00%)}	_0.48s	_0.51s
_{Check Time}	_{10.65s (± 0.35%)}	_{10.63s (± 0.58%)}	_{-0.02s (- 0.15%)}	_10.52s	_10.77s
_{Emit Time}	_{2.33s (± 1.40%)}	_{2.35s (± 1.33%)}	_{+0.02s (+ 0.95%)}	_2.29s	_2.43s
_{Total Time}	_{14.25s (± 0.45%)}	_{14.26s (± 0.39%)}	_{+0.01s (+ 0.05%)}	_14.16s	_14.36s
_{Monaco - node (v10.16.3, x64)}
_{Memory used}	_{355,281k (± 0.03%)}	_{355,226k (± 0.03%)}	_{-55k (- 0.02%)}	_355,063k	_355,454k
_{Parse Time}	_{1.56s (± 0.72%)}	_{1.55s (± 0.75%)}	_{-0.01s (- 0.64%)}	_1.52s	_1.57s
_{Bind Time}	_{0.72s (± 0.68%)}	_{0.72s (± 0.82%)}	_{-0.00s (- 0.00%)}	_0.71s	_0.74s
_{Check Time}	_{5.09s (± 0.34%)}	_{5.10s (± 0.32%)}	_{+0.01s (+ 0.20%)}	_5.07s	_5.15s
_{Emit Time}	_{2.80s (± 0.59%)}	_{2.78s (± 0.83%)}	_{-0.01s (- 0.50%)}	_2.74s	_2.86s
_{Total Time}	_{10.17s (± 0.28%)}	_{10.16s (± 0.38%)}	_{-0.02s (- 0.16%)}	_10.04s	_10.24s
_{TFS - node (v10.16.3, x64)}
_{Memory used}	_{308,168k (± 0.01%)}	_{308,088k (± 0.01%)}	_{-79k (- 0.03%)}	_308,019k	_308,212k
_{Parse Time}	_{1.20s (± 0.56%)}	_{1.20s (± 0.46%)}	_{+0.01s (+ 0.42%)}	_1.19s	_1.22s
_{Bind Time}	_{0.68s (± 0.44%)}	_{0.68s (± 0.87%)}	_{+0.00s (+ 0.44%)}	_0.67s	_0.70s
_{Check Time}	_{4.57s (± 0.58%)}	_{4.58s (± 0.51%)}	_{+0.01s (+ 0.28%)}	_4.54s	_4.64s
_{Emit Time}	_{2.92s (± 0.59%)}	_{2.93s (± 0.98%)}	_{+0.01s (+ 0.41%)}	_2.89s	_3.01s
_{Total Time}	_{9.36s (± 0.40%)}	_{9.40s (± 0.31%)}	_{+0.03s (+ 0.36%)}	_9.31s	_9.45s
_{material-ui - node (v10.16.3, x64)}
_{Memory used}	_{495,552k (± 0.02%)}	_{495,580k (± 0.02%)}	_{+28k (+ 0.01%)}	_495,498k	_495,817k
_{Parse Time}	_{1.98s (± 0.70%)}	_{1.98s (± 0.95%)}	_{+0.01s (+ 0.46%)}	_1.96s	_2.05s
_{Bind Time}	_{0.65s (± 0.68%)}	_{0.65s (± 0.95%)}	_{-0.00s (- 0.15%)}	_0.64s	_0.67s
_{Check Time}	_{13.93s (± 0.40%)}	_{13.88s (± 0.40%)}	_{-0.05s (- 0.36%)}	_13.79s	_14.05s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{16.56s (± 0.38%)}	_{16.52s (± 0.36%)}	_{-0.04s (- 0.27%)}	_16.42s	_16.70s
_{Angular - node (v12.1.0, x64)}
_{Memory used}	_{323,455k (± 0.03%)}	_{323,464k (± 0.03%)}	_{+9k (+ 0.00%)}	_323,336k	_323,775k
_{Parse Time}	_{1.90s (± 0.58%)}	_{1.90s (± 0.55%)}	_{-0.00s (- 0.11%)}	_1.88s	_1.92s
_{Bind Time}	_{0.80s (± 0.62%)}	_{0.80s (± 0.94%)}	_{+0.01s (+ 1.01%)}	_0.79s	_0.82s
_{Check Time}	_{4.84s (± 0.65%)}	_{4.84s (± 0.84%)}	_{-0.00s (- 0.00%)}	_4.79s	_4.99s
_{Emit Time}	_{5.41s (± 0.46%)}	_{5.40s (± 0.43%)}	_{-0.01s (- 0.15%)}	_5.35s	_5.44s
_{Total Time}	_{12.94s (± 0.33%)}	_{12.94s (± 0.43%)}	_{-0.00s (- 0.02%)}	_12.84s	_13.10s
_{Compiler-Unions - node (v12.1.0, x64)}
_{Memory used}	_{199,776k (± 0.11%)}	_{199,846k (± 0.08%)}	_{+70k (+ 0.03%)}	_199,231k	_200,017k
_{Parse Time}	_{0.76s (± 0.92%)}	_{0.76s (± 0.88%)}	_{+0.00s (+ 0.26%)}	_0.75s	_0.78s
_{Bind Time}	_{0.50s (± 0.80%)}	_{0.50s (± 1.12%)}	_{-0.00s (- 0.20%)}	_0.49s	_0.51s
_{Check Time}	_{9.66s (± 0.63%)}	_{9.68s (± 1.02%)}	_{+0.01s (+ 0.16%)}	_9.54s	_9.98s
_{Emit Time}	_{2.37s (± 1.31%)}	_{2.36s (± 1.78%)}	_{-0.01s (- 0.25%)}	_2.27s	_2.46s
_{Total Time}	_{13.29s (± 0.61%)}	_{13.30s (± 0.78%)}	_{+0.01s (+ 0.10%)}	_13.12s	_13.57s
_{Monaco - node (v12.1.0, x64)}
_{Memory used}	_{337,504k (± 0.02%)}	_{337,548k (± 0.02%)}	_{+44k (+ 0.01%)}	_337,375k	_337,671k
_{Parse Time}	_{1.53s (± 0.58%)}	_{1.53s (± 0.58%)}	_{+0.00s (+ 0.07%)}	_1.51s	_1.55s
_{Bind Time}	_{0.70s (± 0.63%)}	_{0.71s (± 0.71%)}	_{+0.00s (+ 0.43%)}	_0.70s	_0.72s
_{Check Time}	_{4.92s (± 0.64%)}	_{4.87s (± 0.57%)}	_{-0.04s (- 0.87%)}	_4.82s	_4.95s
_{Emit Time}	_{2.84s (± 0.45%)}	_{2.84s (± 0.89%)}	_{+0.00s (+ 0.14%)}	_2.80s	_2.92s
_{Total Time}	_{9.98s (± 0.34%)}	_{9.95s (± 0.37%)}	_{-0.03s (- 0.33%)}	_9.89s	_10.04s
_{TFS - node (v12.1.0, x64)}
_{Memory used}	_{292,377k (± 0.03%)}	_{292,383k (± 0.02%)}	_{+6k (+ 0.00%)}	_292,222k	_292,475k
_{Parse Time}	_{1.23s (± 0.73%)}	_{1.22s (± 0.74%)}	_{-0.00s (- 0.33%)}	_1.20s	_1.24s
_{Bind Time}	_{0.66s (± 1.71%)}	_{0.65s (± 0.80%)}	_{-0.01s (- 1.21%)}	_0.64s	_0.66s
_{Check Time}	_{4.50s (± 0.66%)}	_{4.50s (± 0.50%)}	_{-0.00s (- 0.11%)}	_4.46s	_4.56s
_{Emit Time}	_{2.94s (± 1.09%)}	_{2.93s (± 0.77%)}	_{-0.01s (- 0.17%)}	_2.89s	_3.01s
_{Total Time}	_{9.32s (± 0.48%)}	_{9.30s (± 0.35%)}	_{-0.02s (- 0.23%)}	_9.22s	_9.36s
_{material-ui - node (v12.1.0, x64)}
_{Memory used}	_{472,733k (± 0.01%)}	_{472,512k (± 0.07%)}	_{-221k (- 0.05%)}	_471,791k	_472,909k
_{Parse Time}	_{1.99s (± 0.65%)}	_{1.99s (± 0.41%)}	_{+0.00s (+ 0.05%)}	_1.98s	_2.01s
_{Bind Time}	_{0.64s (± 0.69%)}	_{0.65s (± 0.77%)}	_{+0.00s (+ 0.47%)}	_0.64s	_0.66s
_{Check Time}	_{12.47s (± 0.63%)}	_{12.54s (± 1.05%)}	_{+0.07s (+ 0.54%)}	_12.34s	_12.96s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.10s (± 0.60%)}	_{15.17s (± 0.88%)}	_{+0.07s (+ 0.46%)}	_14.99s	_15.60s
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{322,049k (± 0.01%)}	_{322,031k (± 0.01%)}	_{-18k (- 0.01%)}	_321,966k	_322,065k
_{Parse Time}	_{1.91s (± 0.39%)}	_{1.90s (± 0.61%)}	_{-0.01s (- 0.37%)}	_1.88s	_1.93s
_{Bind Time}	_{0.85s (± 0.87%)}	_{0.85s (± 0.61%)}	_{+0.00s (+ 0.12%)}	_0.84s	_0.86s
_{Check Time}	_{4.85s (± 0.29%)}	_{4.85s (± 0.44%)}	_{-0.00s (- 0.02%)}	_4.80s	_4.92s
_{Emit Time}	_{5.45s (± 0.52%)}	_{5.49s (± 0.64%)}	_{+0.04s (+ 0.83%)}	_5.42s	_5.56s
_{Total Time}	_{13.06s (± 0.29%)}	_{13.10s (± 0.40%)}	_{+0.04s (+ 0.29%)}	_12.97s	_13.20s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{200,755k (± 0.56%)}	_{200,635k (± 0.56%)}	_{-120k (- 0.06%)}	_199,088k	_202,928k
_{Parse Time}	_{0.80s (± 0.75%)}	_{0.79s (± 0.46%)}	_{-0.00s (- 0.25%)}	_0.79s	_0.80s
_{Bind Time}	_{0.53s (± 0.89%)}	_{0.53s (± 0.42%)}	_{-0.00s (- 0.75%)}	_0.52s	_0.53s
_{Check Time}	_{9.69s (± 0.61%)}	_{9.72s (± 0.92%)}	_{+0.03s (+ 0.27%)}	_9.60s	_10.02s
_{Emit Time}	_{2.38s (± 1.07%)}	_{2.34s (± 0.94%)}	_{-0.04s (- 1.60%)}	_2.30s	_2.39s
_{Total Time}	_{13.39s (± 0.51%)}	_{13.38s (± 0.76%)}	_{-0.02s (- 0.12%)}	_13.24s	_13.71s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{336,857k (± 0.01%)}	_{336,880k (± 0.01%)}	_{+24k (+ 0.01%)}	_336,841k	_336,930k
_{Parse Time}	_{1.56s (± 0.69%)}	_{1.56s (± 0.67%)}	_{-0.00s (- 0.19%)}	_1.53s	_1.58s
_{Bind Time}	_{0.73s (± 0.79%)}	_{0.73s (± 0.47%)}	_{-0.00s (- 0.41%)}	_0.72s	_0.73s
_{Check Time}	_{4.84s (± 0.38%)}	_{4.85s (± 0.42%)}	_{+0.01s (+ 0.23%)}	_4.80s	_4.89s
_{Emit Time}	_{2.90s (± 0.40%)}	_{2.91s (± 0.48%)}	_{+0.01s (+ 0.31%)}	_2.89s	_2.94s
_{Total Time}	_{10.03s (± 0.21%)}	_{10.05s (± 0.37%)}	_{+0.01s (+ 0.12%)}	_9.96s	_10.13s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{291,529k (± 0.01%)}	_{291,527k (± 0.01%)}	_{-2k (- 0.00%)}	_291,484k	_291,600k
_{Parse Time}	_{1.26s (± 1.06%)}	_{1.25s (± 1.74%)}	_{-0.00s (- 0.24%)}	_1.22s	_1.33s
_{Bind Time}	_{0.69s (± 0.43%)}	_{0.69s (± 0.32%)}	_{-0.00s (- 0.43%)}	_0.68s	_0.69s
_{Check Time}	_{4.50s (± 0.39%)}	_{4.48s (± 0.35%)}	_{-0.02s (- 0.51%)}	_4.45s	_4.52s
_{Emit Time}	_{3.06s (± 0.84%)}	_{3.03s (± 0.62%)}	_{-0.03s (- 0.98%)}	_2.98s	_3.08s
_{Total Time}	_{9.50s (± 0.39%)}	_{9.45s (± 0.34%)}	_{-0.05s (- 0.57%)}	_9.36s	_9.51s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{471,501k (± 0.01%)}	_{471,406k (± 0.06%)}	_{-95k (- 0.02%)}	_470,317k	_471,600k
_{Parse Time}	_{2.04s (± 0.59%)}	_{2.06s (± 0.59%)}	_{+0.02s (+ 0.73%)}	_2.03s	_2.09s
_{Bind Time}	_{0.70s (± 0.32%)}	_{0.70s (± 0.57%)}	_{0.00s ( 0.00%)}	_0.69s	_0.71s
_{Check Time}	_{12.62s (± 0.42%)}	_{12.59s (± 0.87%)}	_{-0.03s (- 0.25%)}	_12.41s	_12.81s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.36s (± 0.35%)}	_{15.35s (± 0.77%)}	_{-0.01s (- 0.07%)}	_15.17s	_15.60s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-198-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{7 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v10.16.3, x64)
node (v12.1.0, x64)
node (v14.15.1, x64)

Scenarios

Angular - node (v10.16.3, x64)
Angular - node (v12.1.0, x64)
Angular - node (v14.15.1, x64)
Compiler-Unions - node (v10.16.3, x64)
Compiler-Unions - node (v12.1.0, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v10.16.3, x64)
Monaco - node (v12.1.0, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v10.16.3, x64)
TFS - node (v12.1.0, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v10.16.3, x64)
material-ui - node (v12.1.0, x64)
material-ui - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₄₁₆₆₀	₁₀
_Baseline	_master	₁₀

typescript-bot · 2021-02-17T01:55:11Z

@DanielRosenwasser
The results of the perf run you requested are in!

Here they are:

Comparison Report - master..41660

_Metric	_master	₄₁₆₆₀	_Delta	_Best	_Worst
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{322,049k (± 0.01%)}	_{322,042k (± 0.01%)}	_{-6k (- 0.00%)}	_321,986k	_322,112k
_{Parse Time}	_{1.91s (± 0.39%)}	_{1.91s (± 0.47%)}	_{-0.00s (- 0.05%)}	_1.89s	_1.93s
_{Bind Time}	_{0.85s (± 0.87%)}	_{0.86s (± 0.58%)}	_{+0.01s (+ 0.71%)}	_0.85s	_0.87s
_{Check Time}	_{4.85s (± 0.29%)}	_{4.84s (± 0.49%)}	_{-0.01s (- 0.19%)}	_4.78s	_4.91s
_{Emit Time}	_{5.45s (± 0.52%)}	_{5.48s (± 0.68%)}	_{+0.03s (+ 0.55%)}	_5.37s	_5.57s
_{Total Time}	_{13.06s (± 0.29%)}	_{13.09s (± 0.28%)}	_{+0.03s (+ 0.21%)}	_12.97s	_13.16s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{200,755k (± 0.56%)}	_{200,577k (± 0.58%)}	_{-178k (- 0.09%)}	_199,057k	_202,960k
_{Parse Time}	_{0.80s (± 0.75%)}	_{0.80s (± 0.62%)}	_{0.00s ( 0.00%)}	_0.79s	_0.81s
_{Bind Time}	_{0.53s (± 0.89%)}	_{0.53s (± 0.00%)}	_{-0.00s (- 0.56%)}	_0.53s	_0.53s
_{Check Time}	_{9.69s (± 0.61%)}	_{9.71s (± 0.69%)}	_{+0.02s (+ 0.18%)}	_9.57s	_9.86s
_{Emit Time}	_{2.38s (± 1.07%)}	_{2.34s (± 1.26%)}	_{-0.04s (- 1.68%)}	_2.29s	_2.41s
_{Total Time}	_{13.39s (± 0.51%)}	_{13.37s (± 0.61%)}	_{-0.02s (- 0.16%)}	_13.21s	_13.60s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{336,857k (± 0.01%)}	_{336,856k (± 0.01%)}	_{-1k (- 0.00%)}	_336,803k	_336,902k
_{Parse Time}	_{1.56s (± 0.69%)}	_{1.56s (± 0.58%)}	_{-0.00s (- 0.00%)}	_1.54s	_1.58s
_{Bind Time}	_{0.73s (± 0.79%)}	_{0.73s (± 0.79%)}	_{0.00s ( 0.00%)}	_0.72s	_0.74s
_{Check Time}	_{4.84s (± 0.38%)}	_{4.84s (± 0.48%)}	_{+0.00s (+ 0.08%)}	_4.79s	_4.91s
_{Emit Time}	_{2.90s (± 0.40%)}	_{2.92s (± 0.77%)}	_{+0.02s (+ 0.55%)}	_2.86s	_2.96s
_{Total Time}	_{10.03s (± 0.21%)}	_{10.05s (± 0.38%)}	_{+0.02s (+ 0.21%)}	_9.98s	_10.13s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{291,529k (± 0.01%)}	_{291,536k (± 0.00%)}	_{+7k (+ 0.00%)}	_291,495k	_291,569k
_{Parse Time}	_{1.26s (± 1.06%)}	_{1.25s (± 1.25%)}	_{-0.01s (- 0.48%)}	_1.22s	_1.29s
_{Bind Time}	_{0.69s (± 0.43%)}	_{0.69s (± 0.75%)}	_{-0.00s (- 0.14%)}	_0.68s	_0.70s
_{Check Time}	_{4.50s (± 0.39%)}	_{4.49s (± 0.40%)}	_{-0.01s (- 0.16%)}	_4.44s	_4.53s
_{Emit Time}	_{3.06s (± 0.84%)}	_{3.05s (± 1.03%)}	_{-0.00s (- 0.10%)}	_3.01s	_3.16s
_{Total Time}	_{9.50s (± 0.39%)}	_{9.48s (± 0.48%)}	_{-0.02s (- 0.20%)}	_9.38s	_9.62s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{471,501k (± 0.01%)}	_{471,547k (± 0.00%)}	_{+45k (+ 0.01%)}	_471,503k	_471,589k
_{Parse Time}	_{2.04s (± 0.59%)}	_{2.06s (± 0.89%)}	_{+0.01s (+ 0.59%)}	_2.01s	_2.09s
_{Bind Time}	_{0.70s (± 0.32%)}	_{0.70s (± 0.88%)}	_{+0.00s (+ 0.29%)}	_0.69s	_0.72s
_{Check Time}	_{12.62s (± 0.42%)}	_{12.61s (± 0.60%)}	_{-0.01s (- 0.06%)}	_12.47s	_12.82s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.36s (± 0.35%)}	_{15.37s (± 0.48%)}	_{+0.01s (+ 0.05%)}	_15.25s	_15.54s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-198-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{7 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v14.15.1, x64)

Scenarios

Angular - node (v14.15.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₄₁₆₆₀	₁₀
_Baseline	_master	₁₀

DanielRosenwasser · 2021-02-19T21:02:13Z

I don't think we're correctly running the community test suite anymore (#42875), so I can't confidently comment on if anything new broke. But I think this is now a "serious PR".

RyanCavanaugh · 2021-02-25T21:47:54Z

Assuming there's nothing too concerning in the user tests, I'm okay with putting this in the nightly and watching for fallout. I stand by the current behavior being a bug 🙂

DanielRosenwasser added 2 commits November 23, 2020 15:42

Only enable special assignability rule on string index signatures to …

02cce51

…'any'.

Accepted baselines.

aaf1b9e

DanielRosenwasser added the Experiment A fork with an experimental idea which might not make it into master label Nov 23, 2020

DanielRosenwasser requested review from RyanCavanaugh, ahejlsberg and sandersn November 23, 2020 23:44

typescript-bot assigned DanielRosenwasser Nov 23, 2020

typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Nov 23, 2020

This comment has been minimized.

Sign in to view

typescript-bot mentioned this pull request Nov 24, 2020

🤖 User test baselines have changed for removeAnyAssignabilityForNumericIndexSignature typescript-bot/TypeScript#109

Open

This comment has been minimized.

Sign in to view

DanielRosenwasser commented Nov 24, 2020

View reviewed changes

DanielRosenwasser marked this pull request as ready for review November 24, 2020 00:58

DanielRosenwasser mentioned this pull request Dec 10, 2020

Design Meeting Notes, 12/9/2020 #41907

Closed

benlesh mentioned this pull request Feb 10, 2021

Remove ArrayLike from ObservableInput ReactiveX/rxjs#6011

Closed

typescript-bot and others added 5 commits February 12, 2021 01:15

Merge remote-tracking branch 'origin/master' into removeAnyAssignabil…

98952dc

…ityForNumericIndexSignature

Added test.

2a28805

Accepted baselines.

bb0f120

Renamed test files.

2326c28

Add non-erroring version of bclas'subClassThisTypeAssignable01.ts'

22dabb8

Accepted baselines.

7dd8232

DanielRosenwasser removed the Experiment A fork with an experimental idea which might not make it into master label Feb 19, 2021

RyanCavanaugh approved these changes Feb 25, 2021

View reviewed changes

DanielRosenwasser merged commit df5ffc0 into master Feb 26, 2021

DanielRosenwasser deleted the removeAnyAssignabilityForNumericIndexSignature branch February 26, 2021 01:36

DanielRosenwasser mentioned this pull request Feb 26, 2021

Design Meeting Notes, 2/24/2021 #42991

Closed

microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025

Conversation

DanielRosenwasser commented Nov 23, 2020

Uh oh!

DanielRosenwasser commented Nov 23, 2020

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

DanielRosenwasser commented Nov 24, 2020

Uh oh!

DanielRosenwasser Nov 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DanielRosenwasser Nov 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DanielRosenwasser commented Nov 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DanielRosenwasser commented Feb 17, 2021

Uh oh!

DanielRosenwasser commented Feb 17, 2021

Uh oh!

typescript-bot commented Feb 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 17, 2021

Uh oh!

typescript-bot commented Feb 17, 2021

Uh oh!

DanielRosenwasser commented Feb 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RyanCavanaugh commented Feb 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DanielRosenwasser Nov 24, 2020 •

edited

Loading

DanielRosenwasser Nov 24, 2020 •

edited

Loading

DanielRosenwasser commented Nov 24, 2020 •

edited

Loading

typescript-bot commented Feb 17, 2021 •

edited

Loading

typescript-bot commented Feb 17, 2021 •

edited

Loading

typescript-bot commented Feb 17, 2021 •

edited

Loading

typescript-bot commented Feb 17, 2021 •

edited

Loading

typescript-bot commented Feb 17, 2021 •

edited

Loading

typescript-bot commented Feb 17, 2021 •

edited

Loading

typescript-bot commented Feb 17, 2021 •

edited

Loading

DanielRosenwasser commented Feb 19, 2021 •

edited

Loading