Skip to content

BigInt type constructor should not accept any type #40877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MattBidewell
Copy link

BigInt type constructor should not accept any type - 38980

Branch made on 01/10.
PR Made on 01/10.

Fixes #38980

@typescript-bot
Copy link
Collaborator

It looks like you've sent a pull request to update our 'lib' files. These files aren't meant to be edited by hand, as they consist of last-known good states of the compiler and are generated from 'src'. Unless this is necessary, consider closing the pull request and sending a separate PR to update 'src'.

@typescript-bot typescript-bot added lib update PR modifies files in the `lib` folder For Backlog Bug PRs that fix a backlog bug labels Oct 1, 2020
@MattBidewell MattBidewell reopened this Oct 1, 2020
@sandersn
Copy link
Member

sandersn commented Oct 9, 2020

@typescript-bot user test this
@typescript-bot run dt

@sandersn sandersn added the Experiment A fork with an experimental idea which might not make it into master label Oct 9, 2020
@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 9, 2020

Heya @sandersn, I've started to run the parallelized community code test suite on this PR at 64ce9c5. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Oct 9, 2020

Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at 64ce9c5. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@sandersn
Copy link
Member

sandersn commented Oct 9, 2020

User tests don't have any new failures.

@fubar
Copy link

fubar commented Mar 12, 2021

@MattBidewell this has been fixed in #43204

@sandersn
Copy link
Member

Thanks for noticing @fubar, and thanks for your PR @MattBidewell

(#43204 is a redo of the older #38995 with a bogus change removed.)

@sandersn sandersn closed this Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Experiment A fork with an experimental idea which might not make it into master For Backlog Bug PRs that fix a backlog bug lib update PR modifies files in the `lib` folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BigInt constructor should not accept any type
4 participants