Skip to content

Swallow empty-commit error #40244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2020
Merged

Swallow empty-commit error #40244

merged 1 commit into from
Aug 25, 2020

Conversation

@amcasey
Copy link
Member

@amcasey amcasey commented Aug 25, 2020

This doesn't affect correctness, but it does spare us a build failure notification.

@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 25, 2020
@amcasey amcasey requested a review from orta August 25, 2020 17:18
@amcasey
Copy link
Member Author

amcasey commented Aug 25, 2020

I didn't use && because I believe it would still have a non-zero exit code.

@amcasey amcasey requested a review from andrewbranch August 25, 2020 17:21
@amcasey amcasey merged commit 2ff70f0 into microsoft:master Aug 25, 2020
@amcasey amcasey deleted the EmptyCommit branch August 25, 2020 17:33
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

+1 more reviewer

@orta orta orta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amcasey @orta @andrewbranch @typescript-bot