Skip to content

Nested assignment to a require alias isn't a declaration #40186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

sandersn
Copy link
Member

This is not something we can type correctly, and doesn't work in Typescript either. Better not to treat it as a declaration in JS.

Fixes #40140

This is not something we can type correctly, and doesn't work in
Typescript either. Better to ignore it in JS.
@sandersn sandersn requested a review from elibarzilay August 21, 2020 22:30
@sandersn sandersn requested a review from weswigham August 21, 2020 22:30
@typescript-bot typescript-bot added the For Milestone Bug PRs that fix a bug with a specific milestone label Aug 21, 2020
@sandersn sandersn merged commit 378083f into master Sep 1, 2020
@sandersn sandersn deleted the disallow-nested-assignment-to-require-aliases branch September 1, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Nested assignment to untyped imports in JS results in error
3 participants