Skip to content

fix(39858): "Convert to async function" refactor generates invalid code with imported functions #40154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 3, 2020
Merged

fix(39858): "Convert to async function" refactor generates invalid code with imported functions #40154

merged 1 commit into from
Nov 3, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #39858

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Aug 20, 2020
sandersn
sandersn requested changes Sep 8, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about the predicate to use.

@sandersn sandersn self-assigned this Sep 8, 2020
@a-tarasyuk a-tarasyuk requested a review from sandersn September 8, 2020 20:15
@sandersn sandersn merged commit ad70313 into microsoft:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uniqueiniquity uniqueiniquity uniqueiniquity approved these changes

@sandersn sandersn sandersn approved these changes

Assignees

@sandersn sandersn

Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: "Convert to async function" refactor generates invalid code with imported functions
4 participants
@a-tarasyuk @sandersn @uniqueiniquity @typescript-bot