Revamp dockerfile for office-ui-fabric to reduce noise #40147
Merged
+13
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dle recent changes to project structure
typescript-bot
added
Author: Team
For Uncommitted Bug
|
Might as well use Node 12. 13 is EOL. |
|
for housekeeping purposes, can you exclude the log diff so it'll show up on the normal user test PR? |
sandersn
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and better handle recent changes to project structure (where explicit TS deps were added throughout the tree in more places than we'd previously recognized).
Mostly this: reverts to
node 13to reduce the runtime warning noise (that's not our fault), uses only thescssandtsbuild steps (to remove noise from rollup and non-ts activities), and sets the build to--bail=false, so an error in an early project doesn't block later projects.