-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Limit auto import provider project size #39855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit auto import provider project size #39855
Conversation
@typescript-bot pack this |
Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 787ea50. You can monitor the build here. |
This should be obvious from the many explanations you've given me, but I keep getting mixed up - are @types packages counted towards the cap? |
Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build. |
It’s actually not totally obvious @amcasey; the answer is that it depends on the user’s tsconfig.json setting. By default, @types packages will be included automatically in the main program, therefore they would not count against this cap, because the cap applies after we’ve filtered out dependencies that are already present in the main program. But if the user sets an explicit |
@typescript-bot pack this |
Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 5abf67c. You can monitor the build here. |
Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build. |
Don’t create an AutoImportProviderProject if it would result in pulling in more than 10 direct dependencies. The angular starter template, for reference, has five.