Skip to content

Reduce unnecessary error computation #39776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Conversation

amcasey
Copy link
Member

@amcasey amcasey commented Jul 27, 2020

...during overload resolution. Based on a trace that was spending 30% of a (very slow) overload resolution elaborating errors that were then dropped.

...during overload resolution.  Based on a trace that was spending 30%
of a (very slow) overload resolution elaborating errors that were then
dropped.
@amcasey amcasey requested a review from weswigham July 27, 2020 21:48
@typescript-bot typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 27, 2020
@amcasey
Copy link
Member Author

amcasey commented Jul 27, 2020

Interestingly, (though, in hindsight, logically), this also affects things like semantic classification that depend on overload resolution to get contextual types.

@amcasey amcasey merged commit 79e2ed2 into microsoft:master Jul 28, 2020
@amcasey amcasey deleted the OverloadErrors branch July 28, 2020 17:35
@amcasey
Copy link
Member Author

amcasey commented Jul 28, 2020

@typescript-bot cherry-pick this to release-4.0

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 28, 2020

Heya @amcasey, I've started to run the task to cherry-pick this into release-4.0 on this PR at 195fad2. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

Hey @amcasey, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.0 manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants