Reduce unnecessary error computation #39776
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...during overload resolution. Based on a trace that was spending 30% of a (very slow) overload resolution elaborating errors that were then dropped.
typescript-bot
added
the
For Uncommitted Bug
|
Interestingly, (though, in hindsight, logically), this also affects things like semantic classification that depend on overload resolution to get contextual types. |
weswigham
approved these changes
Jul 28, 2020
|
@typescript-bot cherry-pick this to release-4.0 |
|
Hey @amcasey, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into release-4.0 manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...during overload resolution. Based on a trace that was spending 30% of a (very slow) overload resolution elaborating errors that were then dropped.