Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better checking of @param/@property tags #39487

Merged
merged 2 commits into from
Jul 8, 2020
Merged

Better checking of @param/@property tags #39487

merged 2 commits into from
Jul 8, 2020

Commits on Jul 7, 2020

  1. More consistent checking of @property/@param 

    1. Use getWidenedTypeForVariableLikeDeclaration, instead of directly
calling tryGetTypeFromEffectiveTypeNode. This requires some changes in
the former function since it can't assume that the declaration has an
initializer.
2. isOptional now calls isOptionalJSDocPropertyLikeTag.
3. isOptionalJSDocPropertyLikeTag now handles JSDocPropertyTag
(previously it was named isOptionalJSDocParameterTag).
    @sandersn
    sandersn committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    3fef517 View commit details
    Browse the repository at this point in the history

  2. rename to isOptionalJSDocPropertyLikeTag

    @sandersn
    sandersn committed Jul 7, 2020
    Configuration menu
    Copy the full SHA
    c11528a View commit details
    Browse the repository at this point in the history