Skip to content

Conversation

@ShuiRuTian
Copy link
Contributor

Fixes #39384

@orta
Copy link
Contributor

orta commented Jul 6, 2020

Nice work @ShuiRuTian - this looks good to me, thanks!

@orta orta merged commit f29e03e into microsoft:master Jul 6, 2020
@n4zim
Copy link

n4zim commented Nov 10, 2020

Hi !

Thanks @ShuiRuTian for this feature. I have however a recommendation for a case that doesn't work on my side.

So this will work :

const test1 = <Self extends { test: number }>(s: Self) => s
test1({  } as const)

But not that :

const test2 = <Self extends { test: number }>(s: () => Self) => s
test2(() => ({  } as const))

What do you think ?

Thank you for your help.

n4zim added a commit to blue-forest/kiwi-bundle-react that referenced this pull request Nov 10, 2020
@ShuiRuTian
Copy link
Contributor Author

@n4zim
Thanks for feedback, the fix PR is on the way~

@n4zim
Copy link

n4zim commented Nov 10, 2020

@ShuiRuTian It's really nice of you, this well really going to help me. Many thanks !

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants