Skip to content

fix(39047): Default formatter cant format JS Optional catch binding properly #39306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 29, 2020
Merged

fix(39047): Default formatter cant format JS Optional catch binding properly #39306

merged 1 commit into from
Jun 29, 2020

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #39047

@a-tarasyuk a-tarasyuk changed the title fix(39047): handle extra spaces after the catch statement fix(39047): Default formatter cant format JS Optional catch binding properly Jun 28, 2020
andrewbranch
andrewbranch approved these changes Jun 29, 2020
View reviewed changes
Copy link
Member

@andrewbranch andrewbranch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @a-tarasyuk! 🌟

@andrewbranch andrewbranch added the For Milestone Bug PRs that fix a bug with a specific milestone label Jun 29, 2020
@andrewbranch andrewbranch merged commit ee5c3fa into microsoft:master Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbranch andrewbranch andrewbranch approved these changes

Assignees
No one assigned
Labels
For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default formatter cant format JS Optional catch binding properly
2 participants
@a-tarasyuk @andrewbranch