-
Notifications
You must be signed in to change notification settings - Fork 13.1k
String literal rename support #39298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
String literal rename support #39298
Conversation
|
@typescript-bot pack this. |
|
Hey @Kingwl, I've packed this into an installable tgz. You can install it for testing by referencing it in your and then running There is also a playground for this build. |
|
@typescript-bot test this. |
|
UP 👆 |
|
@Kingwl have you checked out what happened with the tests? If you can fix those soon, I think we can get this in before 4.1 beta. |
|
Sorry for the delay. I'm on vacation this weekend. |
andrewbranch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Kingwl! Since this is really a feature and we’re past the 4.1 beta, I think we’re going to hold it for 4.2. I’ll come back to merge as soon as we cut the release branch.
| } | ||
| const d: 'foo' = 'foo' | ||
| declare const f: Foo | ||
| f.f = 'foo' No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| f.f = 'foo' | |
| f.f = 'foo' | |
add new line
|
Hi, is it known issue that in such cases renaming doesn't work Checked on |
|
Well. Even the current implement has many limitation. But I don't think That is expected. Could you create an issue to track that please? |
|
@Kingwl |
Fixes #5602