Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 User test baselines have changed for refs/heads/master #39220

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

typescript-bot
Copy link
Collaborator

This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.

cc @microsoft/typescript

@typescript-bot typescript-bot force-pushed the user-baseline-updates branch 29 times, most recently from 31aa2d5 to d90b47d Compare June 29, 2020 21:41
@typescript-bot typescript-bot force-pushed the user-baseline-updates branch 25 times, most recently from 4eaa4c9 to ee8e904 Compare July 8, 2020 04:40
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes, looks to me.

@@ -54,10 +64,6 @@ Warning: dist/packages/compiler-core/src/options.d.ts:69:42 - (tsdoc-escape-righ
Warning: dist/packages/compiler-core/src/options.d.ts:69:43 - (tsdoc-escape-right-brace) The "}" character should be escaped using a backslash to avoid confusion with a TSDoc inline tag
Warning: dist/packages/compiler-core/src/options.d.ts:69:35 - (tsdoc-malformed-inline-tag) Expecting a TSDoc tag starting with "{@"
Warning: dist/packages/compiler-core/src/options.d.ts:69:36 - (tsdoc-malformed-inline-tag) Expecting a TSDoc tag starting with "{@"
Warning: /vue-next/packages/runtime-dom/src/components/Transition.ts:71:5 - (TS7022) 'name' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code is gone now afaict

@uifabric/build: warning package.json: "dependencies" has dependency "typescript" with range "3.7.2" that collides with a dependency in "devDependencies" of the same name with version "../typescript.tgz"
@uifabric/build: (node:146) Warning: Accessing non-existent property 'cat' of module exports inside circular dependency
@uifabric/build: (Use `node --trace-warnings ...` to show where the warning was created)
@uifabric/build: (node:146) Warning: Accessing non-existent property 'cd' of module exports inside circular dependency
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this error now happens in many packages

@@ -77,8 +77,8 @@ node_modules/adonis-framework/src/Exceptions/index.js(178,21): error TS2554: Exp
node_modules/adonis-framework/src/Exceptions/index.js(191,21): error TS2554: Expected 0 arguments, but got 3.
node_modules/adonis-framework/src/Exceptions/index.js(205,21): error TS2554: Expected 0 arguments, but got 3.
node_modules/adonis-framework/src/File/index.js(175,5): error TS2322: Type 'Promise<any>' is not assignable to type 'boolean'.
node_modules/adonis-framework/src/File/index.js(273,5): error TS2322: Type 'boolean | ""' is not assignable to type 'boolean'.
Type '""' is not assignable to type 'boolean'.
node_modules/adonis-framework/src/File/index.js(273,5): error TS2322: Type 'string | boolean' is not assignable to type 'boolean'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better error messages!

lib/adapters/http.js(249,40): error TS2345: Argument of type 'null' is not assignable to parameter of type 'string | undefined'.
lib/adapters/http.js(278,42): error TS2345: Argument of type 'null' is not assignable to parameter of type 'string | undefined'.
lib/adapters/http.js(239,15): error TS2322: Type 'string' is not assignable to type 'Buffer'.
lib/adapters/http.js(239,45): error TS2345: Argument of type 'Buffer' is not assignable to parameter of type 'string'.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new code in axios here

Property 'resolveOptions' is missing in type 'Pick<ContextOptions & ContextModuleOptionsExtras, "include" | "regExp" | "chunkName" | "referencedExports" | "mode" | "recursive" | ... 6 more ... | "resourceQuery">' but required in type 'ContextModuleOptionsExtras'.
lib/ContextModule.js(346,32): error TS2345: Argument of type 'Pick<ContextOptions & ContextModuleOptionsExtras, "include" | "regExp" | "chunkName" | "referencedExports" | "mode" | "recursive" | ... 7 more ... | "resourceFragment">' is not assignable to parameter of type 'ContextOptions & ContextModuleOptionsExtras'.
Property 'resolveOptions' is missing in type 'Pick<ContextOptions & ContextModuleOptionsExtras, "include" | "regExp" | "chunkName" | "referencedExports" | "mode" | "recursive" | ... 7 more ... | "resourceFragment">' but required in type 'ContextModuleOptionsExtras'.
lib/dependencies/HarmonyExportImportedSpecifierDependency.js(86,37): error TS1016: A required parameter cannot follow an optional parameter.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from fixed optional-parameter checking

@sandersn sandersn merged commit 3f731c2 into microsoft:master Jul 8, 2020
cangSDARM added a commit to cangSDARM/TypeScript that referenced this pull request Jul 9, 2020
* upstream/master: (75 commits)
  Insert auto-imports in sorted order (microsoft#39394)
  LEGO: check in for master to temporary branch.
  Better checking of @param/@Property tags (microsoft#39487)
  fix(25155): add space before optional parameters/properties (microsoft#38798)
  Add regression test for microsoft#38834 (microsoft#39479)
  Fixes searches for symbols exported using export * as (microsoft#39507)
  fix(39421): omit prefix text for rest binding element (microsoft#39433)
  fix(39440): show QF for abstract classes with methods which include 'this' parameter (microsoft#39465)
  Remove unnecessary assert (microsoft#39483)
  LEGO: check in for master to temporary branch.
  Update user baselines (microsoft#39220)
  Type `this` in more constructor functions (microsoft#39447)
  LEGO: check in for master to temporary branch.
  LEGO: check in for master to temporary branch.
  Properly handle rest parameters in function declarations with @type annotations (microsoft#39473)
  Ensure type/namespaceish statics are included in the list of namespace merge members (microsoft#38920)
  Fix getTypeAtLocation for dotted implements clauses (microsoft#39363)
  Add workflow_dispatch to our nightly publish script. (microsoft#39485)
  Fix crash in decorator metadata calculation when serializing template literal type nodes (microsoft#39481)
  Fix test semantic merge conflict between microsoft#39348 and microsoft#39130 (microsoft#39478)
  ...

# Conflicts:
#	src/compiler/scanner.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants