Show a diff when the public api baselines fail #39108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orta
force-pushed
the
show_diff_public_API
branch
2 times, most recently
from
f0471c3 to
605c268
Compare
|
@typescript-bot pack this |
|
Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 605c268. You can monitor the build here. |
|
Yeah, it shows failing results in the pack: https://typescript.visualstudio.com/TypeScript/_build/results?buildId=76845&view=logs&j=fd490c07-0b22-5182-fac9-6d67fe1e939b&t=ec339c2b-c439-539d-f401-d5569bbc95f9 |
|
@orta how hard would it be to un-red the diff? It’s red because it’s part of the error message but at a glance I read that whole thing as deleted lines. |
|
I guess get rid of the test comment and let's merge so that we can iterate on the UX |
… show_diff_public_API
orta
force-pushed
the
show_diff_public_API
branch
from
605c268 to
20a5f69
Compare
|
I did both, will merge on green |
andrewbranch
approved these changes
Jun 17, 2020
RyanCavanaugh
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the jsdiff library which is already in our dependency tree to echo out the public API baseline differences.
Why
These tend to fail more on master, and you don't get to see what's up: https://github.com/microsoft/TypeScript/runs/779388787?check_suite_focus=true#step:4:170
Alternatives
process.env.CIand always do this for all baselinesFourSlash.showTextDiff, I did this initially, but it doesn't do a good job on large files as it prints the entire thing, not a focused subsetLooks like:
If/when this is +1'd - I'll edit the PR to remove the failing test