-
Notifications
You must be signed in to change notification settings - Fork 12.9k
Always syntax only #38564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always syntax only #38564
Conversation
…ith noResolve and can handle semantic operations
@typescript-bot pack this |
Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at d35ffe0. You can monitor the build here. |
Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build. |
@mjbvz @minestarks @uniqueiniquity @amcasey @DanielRosenwasser @RyanCavanaugh |
This is pretty cool. |
Maybe we should disable semantic diagnostics, since a lot of identifiers won't bind? |
F12 is showing me entries from lib.es2015.*.d.ts - were we expecting those to get pulled in? |
I'm having trouble wrapping my head around exactly how this will work if VS continues to send |
I'm excited - I think this will be a great experience during project load. My main concern is that we might regress the syntax server during normal operation. I think it's worth moving ahead and making targeted fixes if that turns out to be a problem. |
Wont cancellation tokens help with that |
Yes i didnt do that here intentionally here till we get some feedback . |
I expect the memory usage to increase, which could be poorly received by the division (and users, if they notice). The effectiveness of cancellation is harder to predict because VS has (so far) limited usage of the syntax server to things that need to be "instantaneous" and cancellation may not be fast enough to retain that performance. |
@typescript-bot pack this |
Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at d35ffe0. You can monitor the build here. |
Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build. |
@typescript-bot pack this |
Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at 93b2723. You can monitor the build here. |
Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your
and then running There is also a playground for this build. |
Fixes #