Skip to content

Always syntax only #38564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Always syntax only #38564

wants to merge 8 commits into from

Conversation

sheetalkamat
Copy link
Member

Fixes #

@sheetalkamat
Copy link
Member Author

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 13, 2020

Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at d35ffe0. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented May 14, 2020

Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/73863/artifacts?artifactName=tgz&fileId=FBF5E81667C77395E73A7860E5CCDEFF7D8CAEBE1871B00517F2FDE022E67E1502&fileName=/typescript-4.0.0-insiders.20200514.tgz"
    }
}

and then running npm install.


There is also a playground for this build.

@sheetalkamat
Copy link
Member Author

@mjbvz @minestarks @uniqueiniquity @amcasey @DanielRosenwasser @RyanCavanaugh
#38564 (comment) is build where syntaxOnly server can accept semantic commands as tsserver without --syntaxOnly also works as if it was passed in. This is on top of #38561

@amcasey
Copy link
Member

amcasey commented May 15, 2020

This is pretty cool.

@amcasey
Copy link
Member

amcasey commented May 15, 2020

Maybe we should disable semantic diagnostics, since a lot of identifiers won't bind?

@amcasey
Copy link
Member

amcasey commented May 15, 2020

F12 is showing me entries from lib.es2015.*.d.ts - were we expecting those to get pulled in?

@amcasey
Copy link
Member

amcasey commented May 15, 2020

I'm having trouble wrapping my head around exactly how this will work if VS continues to send openExternalProjects, but I think I've convinced myself it's not a problem.

@amcasey
Copy link
Member

amcasey commented May 15, 2020

I'm excited - I think this will be a great experience during project load. My main concern is that we might regress the syntax server during normal operation. I think it's worth moving ahead and making targeted fixes if that turns out to be a problem.

@sheetalkamat
Copy link
Member Author

sheetalkamat commented May 15, 2020

My main concern is that we might regress the syntax server during normal operation.

Wont cancellation tokens help with that

@sheetalkamat
Copy link
Member Author

Maybe we should disable semantic diagnostics, since a lot of identifiers won't bind?

Yes i didnt do that here intentionally here till we get some feedback .
I think other potential as compile on save and and similar.. Infact I think enabling selected ones is better approach than disabling few.. Eg completions, quickInfo, goto def, questionably: find all refs

@amcasey
Copy link
Member

amcasey commented May 18, 2020

My main concern is that we might regress the syntax server during normal operation.

Wont cancellation tokens help with that

I expect the memory usage to increase, which could be poorly received by the division (and users, if they notice). The effectiveness of cancellation is harder to predict because VS has (so far) limited usage of the syntax server to things that need to be "instantaneous" and cancellation may not be fast enough to retain that performance.

@DanielRosenwasser
Copy link
Member

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 2, 2020

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at d35ffe0. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 2, 2020

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/75534/artifacts?artifactName=tgz&fileId=38D0F7317D05E75E5D7562B9A10EED35EC9640564F25A30F3AE571738049D55A02&fileName=/typescript-4.0.0-insiders.20200602.tgz"
    }
}

and then running npm install.


There is also a playground for this build.

@sheetalkamat sheetalkamat changed the base branch from master to syntaxAsSemanticServer June 13, 2020 00:09
@sheetalkamat
Copy link
Member Author

@typescript-bot pack this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 13, 2020

Heya @sheetalkamat, I've started to run the tarball bundle task on this PR at 93b2723. You can monitor the build here.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jun 13, 2020

Hey @sheetalkamat, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/76344/artifacts?artifactName=tgz&fileId=7C30A6B3CA28F7C9FB005488BF77DC40D1EAB2DC25BD4E97547911BB09B4EFEF02&fileName=/typescript-4.0.0-insiders.20200613.tgz"
    }
}

and then running npm install.


There is also a playground for this build.

Base automatically changed from syntaxAsSemanticServer to master June 16, 2020 20:39
@sheetalkamat sheetalkamat deleted the alwaysSyntaxOnly branch June 18, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants