fix(38463): No indexed access completions after Record<...>

[a-tarasyuk]

Fixes #38463

[DanielRosenwasser]

@typescript-bot pack this

[DanielRosenwasser]

Does this also fix #38667?

[typescript-bot]

Heya @DanielRosenwasser, I've started to run the tarball bundle task on this PR at 453b1dd. You can monitor the build here.

[typescript-bot]

Hey @DanielRosenwasser, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/74425/artifacts?artifactName=tgz&fileId=C30B5A5C71CC8F6D612F8A75119A31612247E496E99026FB8C3A981C16BF8E0502&fileName=/typescript-4.0.0-insiders.20200520.tgz"
    }
}

and then running npm install.

---

There is also a playground for this build.

[a-tarasyuk]

@DanielRosenwasser

Does this also fix #38667?

It seems, yes.

The problem is filtering private identifiers because to check if a property is a private identifier, completions use.valueDeclaration, which in some cases may be undefined. I'm not sure that even we need to use prop.syntheticOrigin.valueDeclaration, maybe just checking for .valueDeclaration` is enough. What do you think?

[DanielRosenwasser]

I think valueDeclaration should be enough - I'd give it a shot.

It seems, yes.

Would be super grateful if you could add it as a test. 🙂