Make Iterable Map constructor argument optional

[JaredNeil]

Fixes #37779

[msftclas]

All CLA requirements met.

[JaredNeil]

Anything needed to get this merged?

[sandersn]

@typescript-bot user test this
@typescript-bot test this
@typescript-bot run dt

[typescript-bot]

Heya @sandersn, I've started to run the extended test suite on this PR at 1754492. You can monitor the build here.

[typescript-bot]

Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at 1754492. You can monitor the build here.

[typescript-bot]

Heya @sandersn, I've started to run the parallelized community code test suite on this PR at 1754492. You can monitor the build here.

[typescript-bot]

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

[sandersn]

Looks like VS Code and Puppeteer fail to compile with this change.

[JaredNeil]

Is this possibly because this PR is now a couple months old? Should I try to rebase my changes on master first? If that's not likely to be the issue, are there instructions for running those tests myself to reproduce the issue?

[sandersn]

For VS Code, I just followed their instructions to clone and get started developing. Then I opened the file with the error. For puppeteer, you can probably skip that by running gulp runtests --ru=user --t=puppeteer, then opening the puppeteer repo at tests/cases/user/puppeteer/puppeteer/

[sandersn]

Puppeteer's error is of the form

const m = new Map();
const v = m.get('k')
v.push // 'push' not found on 'unknown'

Previously m: Map<any, any> and v: any, but now m: Map<unknown, unknown> and v: unknown. Overload resolution chooses a stricter overload now.

Edit: VS Code has the same problem as puppeteer.

[sandersn]

It could be that lib.es2015.iterable.d.ts is loaded before lib.es2015.collection.d.ts, so the nullary overload matches first. You can try adding new (): Map<any,any> to es2015.iterable.d.ts as the first entry too.

[sandersn]

Need a test to show that

const m = new Map()

still has m: Map<any, any>

[sandersn]

@JaredNeil did you want to keep working on this?

[sandersn]

This PR hasn't seen any activity for quite a while, so I'm going to close it to keep the number of open PRs manageable. Feel free to open a fresh PR or continue the discussion here.