Filter undefined from binding elements with initialisers without undefined in the type #38122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weswigham
reviewed
Apr 22, 2020
src/compiler/checker.ts
Outdated
Comment on lines
7308
to
7314
| // Filter `undefined` from the type we check against if the parent has an initializer without undefined in the type | ||
| else if (strictNullChecks && pattern.parent.initializer) { | ||
| const symbol = getSymbolOfNode(pattern.parent.initializer); | ||
| if (symbol && getTypeFacts(getTypeOfSymbol(symbol)) & TypeFacts.EQUndefined) { | ||
| parentType = getTypeWithFacts(parentType, TypeFacts.NEUndefined); | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| // Filter `undefined` from the type we check against if the parent has an initializer without undefined in the type | |
| else if (strictNullChecks && pattern.parent.initializer) { | |
| const symbol = getSymbolOfNode(pattern.parent.initializer); | |
| if (symbol && getTypeFacts(getTypeOfSymbol(symbol)) & TypeFacts.EQUndefined) { | |
| parentType = getTypeWithFacts(parentType, TypeFacts.NEUndefined); | |
| } | |
| } | |
| // Filter `undefined` from the type we check against if the parent has an initializer and that initializer is not possibly `undefined` | |
| else if (strictNullChecks && pattern.parent.initializer) { | |
| const initializerType = getTypeOfInitializer(pattern.parent.initializer); | |
| if (getTypeWithFacts(initializerType, TypeFacts.NEUndefined) === initializerType) { | |
| parentType = getTypeWithFacts(parentType, TypeFacts.NEUndefined); | |
| } | |
| } |
weswigham
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.