Fix use-before-def with methods on esnext+useDefineForClassFields #38033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was incorrectly flagging methods as used before their definition, but this is allowed under any emit.
elibarzilay
reviewed
Apr 20, 2020
...nce/classes/propertyMemberDeclarations/assignParameterPropertyToPropertyDeclarationESNext.ts
Show resolved
Hide resolved
elibarzilay
approved these changes
Apr 20, 2020
sandersn
deleted the
fix-use-before-def-methods-esnext-useDefineForClassFields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was incorrectly flagging methods as used before their definition, but this is allowed under any emit.
The esnext+useDefineForClassFields-specific error should only apply to properties, but incorrectly applied to any declaration. This change makes it only apply to properties.
Fixes #37573