New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for in narrowing #37858

Closed

Kingwl wants to merge 3 commits into microsoft:master from Kingwl:in-narrow

Contributor

Kingwl commented Apr 9, 2020 •

edited

Loading

Fixes #21732

This or add existed key narrowing by in operator according #31132 by Generate an intersection with { a: unknown }.

wip

ba521ce

Contributor Author

Kingwl commented Apr 9, 2020

Some problems:

Should we narrow it if distribution failed?
If so, should we narrow it if any member of the union is undefined/null/number?

Kingwl added 2 commits

April 9, 2020 18:06


          fix more case

487dff7


          accept baseline

879f69e

Kingwl force-pushed the in-narrow branch from 399ad72 to 879f69e Compare

April 9, 2020 10:19

Kingwl closed this

typescript-bot added the For Backlog Bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Backlog Bug