Add outlining spans for case clauses #37374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkamat
approved these changes
Mar 12, 2020
Member
sheetalkamat
left a comment
sheetalkamat
left a comment
There was a problem hiding this comment.
I think you need to update existing baselines but otherwise change looks good
Member
Author
|
Oh, I think I need |
Member
Author
|
Actually a lot of these errors in CI look completely unrelated. Weird 🤔 |
mjbvz
approved these changes
Mar 12, 2020
Contributor
mjbvz
left a comment
mjbvz
left a comment
There was a problem hiding this comment.
Behavior looks great! Thanks for taking a look
Member
|
Merge from master .. I noticed master was broken yesterday by two PRs and had fixed it |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23380