fix(37287): False positive for TS2448 "use before declaration" in 3.8.3 --target esnext #37323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jessidhia
reviewed
Mar 11, 2020
|
|
||
| a() | ||
| >a() : any | ||
| >a : () => any |
There was a problem hiding this comment.
Interesting that this is the result type; I guess because --strictNullChecks is off by default in tests?
Might be better to change from () => null to () => 0 just to make sure the types propagate properly (or enable --strict)
There was a problem hiding this comment.
I don't think types matter that much for this test since it's just trying to show the absence of an error.
sandersn
approved these changes
Mar 19, 2020
|
|
||
| a() | ||
| >a() : any | ||
| >a : () => any |
There was a problem hiding this comment.
I don't think types matter that much for this test since it's just trying to show the absence of an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37287