Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary assert #37059

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Remove unnecessary assert #37059

merged 1 commit into from
Feb 26, 2020

Conversation

sheetalkamat
Copy link
Member

(since we allow already open file to be opened again even through openFile command - partially) from updateOpen command

Fixes #35034

@sheetalkamat
Remove unnecessary assert (since we allow already open file to be ope…
724c755 
…ned again even through openFile command - partially) from updateOpen command

Fixes #35034
@sheetalkamat
Copy link
Member Author

@typescript-bot cherry-pick this to release-3.8 branch

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 26, 2020 •
edited
Loading

Heya @sheetalkamat, I've started to run the task to cherry-pick this into release-3.8 on this PR at 724c755. You can monitor the build here.

@sheetalkamat sheetalkamat added this to the TypeScript 3.8.3 milestone Feb 26, 2020
typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Feb 26, 2020
@sheetalkamat @typescript-bot
Cherry-pick PR microsoft#37059 into release-3.8
75dac2f 
Component commits:
724c755 Remove unnecessary assert (since we allow already open file to be opened again even through openFile command - partially) from updateOpen command Fixes microsoft#35034
@typescript-bot typescript-bot mentioned this pull request Feb 26, 2020
Merged
@typescript-bot
Copy link
Collaborator

Hey @sheetalkamat, I've opened #37060 for you.

@sheetalkamat sheetalkamat merged commit 05c9ec3 into master Feb 26, 2020
@sheetalkamat sheetalkamat deleted the openScriptInfo branch February 26, 2020 23:25
sheetalkamat added a commit that referenced this pull request Feb 26, 2020
@sheetalkamat
Cherry-pick PR #37059 into release-3.8 (#37060)
9bf6058 
Component commits:
724c755 Remove unnecessary assert (since we allow already open file to be opened again even through openFile command - partially) from updateOpen command Fixes #35034

Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

@sandersn sandersn Awaiting requested review from sandersn

Assignees

@sheetalkamat sheetalkamat

Labels
Author: Team
Projects
None yet
Milestone
TypeScript 3.8.3
Development

Successfully merging this pull request may close these issues.

Error: Debug Failure. False expression. in 'ProjectService.applyChangesInOpenFiles' during 'updateOpen'
3 participants
@sheetalkamat @typescript-bot @RyanCavanaugh