Skip to content

Remove unnecessary assert #37059

Merged
sheetalkamat merged 1 commit intomasterfrom
openScriptInfo
Feb 26, 2020
Merged

Remove unnecessary assert #37059
sheetalkamat merged 1 commit intomasterfrom
openScriptInfo

Conversation

@sheetalkamat
Copy link
Member

(since we allow already open file to be opened again even through openFile command - partially) from updateOpen command

Fixes #35034

…ned again even through openFile command - partially) from updateOpen command

Fixes #35034
@sheetalkamat
Copy link
Member Author

@typescript-bot cherry-pick this to release-3.8 branch

@typescript-bot
Copy link
Collaborator

typescript-bot commented Feb 26, 2020

Heya @sheetalkamat, I've started to run the task to cherry-pick this into release-3.8 on this PR at 724c755. You can monitor the build here.

@sheetalkamat sheetalkamat added this to the TypeScript 3.8.3 milestone Feb 26, 2020
typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Feb 26, 2020
Component commits:
724c755 Remove unnecessary assert (since we allow already open file to be opened again even through openFile command - partially) from updateOpen command Fixes microsoft#35034
@typescript-bot
Copy link
Collaborator

Hey @sheetalkamat, I've opened #37060 for you.

@sheetalkamat sheetalkamat merged commit 05c9ec3 into master Feb 26, 2020
@sheetalkamat sheetalkamat deleted the openScriptInfo branch February 26, 2020 23:25
sheetalkamat added a commit that referenced this pull request Feb 26, 2020
Component commits:
724c755 Remove unnecessary assert (since we allow already open file to be opened again even through openFile command - partially) from updateOpen command Fixes #35034

Co-authored-by: Sheetal Nandi <shkamat@microsoft.com>
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: Debug Failure. False expression. in 'ProjectService.applyChangesInOpenFiles' during 'updateOpen'

3 participants