fix(36989): 'async' modifier cannot be used in an ambient context.ts#37010
Merged
weswigham merged 4 commits intomicrosoft:masterfrom Feb 27, 2020
Merged
fix(36989): 'async' modifier cannot be used in an ambient context.ts#37010weswigham merged 4 commits intomicrosoft:masterfrom
weswigham merged 4 commits intomicrosoft:masterfrom
Conversation
Contributor
|
Was hoping somebody could trigger a build of this. |
Member
|
@rbuckton can you review? Looking at taking this into 3.8.3 |
weswigham
reviewed
Feb 27, 2020
weswigham
approved these changes
Feb 27, 2020
Member
|
@typescript-bot cherry-pick this into release-3.8 |
Collaborator
|
Heya @weswigham, I've started to run the task to cherry-pick this into |
typescript-bot
pushed a commit
to typescript-bot/TypeScript
that referenced
this pull request
Feb 27, 2020
Component commits: 4605c34 fix(36989): omit 'async' modifier for methods in declaration files. c144e5e Merge branch 'master' of https://github.com/Microsoft/TypeScript into bug/36989 fb7fd42 remove useless condition c2b709a Merge branch 'master' of https://github.com/Microsoft/TypeScript into bug/36989
Collaborator
|
Hey @weswigham, I've opened #37072 for you. |
weswigham
pushed a commit
that referenced
this pull request
Feb 27, 2020
Component commits: 4605c34 fix(36989): omit 'async' modifier for methods in declaration files. c144e5e Merge branch 'master' of https://github.com/Microsoft/TypeScript into bug/36989 fb7fd42 remove useless condition c2b709a Merge branch 'master' of https://github.com/Microsoft/TypeScript into bug/36989 Co-authored-by: Alexander T. <alexander.tarasyuk@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36989