Fix find-refs crash on JSDocNamepath #36941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSDocNamepaths span a lot of identifiers that we don't actually care about, so it's incorrect for createChildren to add its children as synthetic nodes.
andrewbranch
approved these changes
Feb 21, 2020
|
We tried really hard to ignore them and finally had to write code to explicitly ignore them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSDocNamepaths span a lot of identifiers that we don't actually care about, so it's incorrect for createChildren to add its children as synthetic nodes.
Fixes #36338
Not sure who is best to review this, so I'm going with @andrewbranch and @orta since I believe @orta wrote support for JSDocNamepaths and I think @andrewbranch has worked with services a bit.