🤖 User test baselines have changed for refs/heads/release-3.8 #36815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
typescript-bot
force-pushed
the
user-update-Microsoft-20200106-refs/heads/release-3.8
branch
from
110f5e7 to
e5cfa5a
Compare
typescript-bot
force-pushed
the
user-update-Microsoft-20200106-refs/heads/release-3.8
branch
from
e5cfa5a to
39c89c4
Compare
sandersn
requested changes
Feb 18, 2020
Member
sandersn
left a comment
sandersn
left a comment
There was a problem hiding this comment.
azure-sdk has a new parse error. I'm investigating
| @azure/service-bus (? seconds) | ||
| >>> @azure/service-bus | ||
| tsc -p . && rollup -c 2>&1 && npm run extract-api | ||
| src/serviceBusClient.ts(90,34): error TS1109: Expression expected. |
Member
There was a problem hiding this comment.
this looks bad and is not in master
Member
There was a problem hiding this comment.
file hasn't changed since November
Member
There was a problem hiding this comment.
Never mind, I was looking at an old commit. There was a commit 4 days ago that added a couple of ?. uses. This fails to parse, which makes me think that the TS we're using isn't actually latest.
- can you take a look?
- do you want to merge this in the meantime?
Member
There was a problem hiding this comment.
It is now in master, so might as well fix it there.
sandersn
approved these changes
Feb 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @microsoft/typescript