Allow deeply nested immediately resolving conditionals without any syntactic requirements #36584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Same comment as #36583 (comment). It also seems like this solution might overapply and escape the depth limit in incorrect cases. |
|
@typescript-bot cherry-pick this into nestedConditionalTypes |
|
Hey @weswigham, I couldn't open a PR with the cherry-pick. (You can check the log here). You may need to squash and pick this PR into nestedConditionalTypes manually. |
weswigham
force-pushed
the
allow-deeply-nested-conditionals-without-complexity
branch
from
073faae
to
87eb951
Compare
…ntactic requirements or implementation contortions Extract logic into function
weswigham
force-pushed
the
allow-deeply-nested-conditionals-without-complexity
branch
from
87eb951
to
8b4744a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
or implementation contortions. We already don't cache anything or create intermediate instantiations in the immediate simplification cases, so all we needed to do was except the instantiation depth limit in those scenarios.
Much simpler alternative to #36583, as a point of comparison.
Fixes #28663