Skip to content

🤖 User test baselines have changed for contextualTypingFixes #36480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+218 −201
Closed

🤖 User test baselines have changed for contextualTypingFixes #36480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/baselines/reference/docker/azure-sdk.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,18 +150,18 @@ npm ERR! This is probably not a problem with npm. There is likely additional log
npm ERR! A complete log of this run can be found in:
npm ERR! /root/.npm/_logs/XXXX-XX-XXXXXXXXX-debug.log
================================
Error: Project(s) failed to build
Error: Project(s) failed
rush rebuild - Errors! ( ? seconds)



Standard error:

XX of XX: [@azure/app-configuration] failed to build!
XX of XX: [@azure/app-configuration] failed!
XX of XX: [@azure/cosmos] completed with warnings in ? seconds
XX of XX: [@azure/eventhubs-checkpointstore-blob] failed to build!
XX of XX: [@azure/keyvault-certificates] failed to build!
XX of XX: [@azure/storage-file-datalake] failed to build!
XX of XX: [@azure/eventhubs-checkpointstore-blob] failed!
XX of XX: [@azure/keyvault-certificates] failed!
XX of XX: [@azure/storage-file-datalake] failed!
[@azure/app-configuration] Returned error code: 2
[@azure/eventhubs-checkpointstore-blob] Returned error code: 2
[@azure/keyvault-certificates] Returned error code: 2
Expand Down
315 changes: 148 additions & 167 deletions tests/baselines/reference/docker/office-ui-fabric.log
View file
Open in desktop

Large diffs are not rendered by default.

22 changes: 20 additions & 2 deletions tests/baselines/reference/docker/vscode.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,29 @@
Exit Code: 0
Exit Code: 1
Standard output:
yarn run vX.X.X
$ gulp compile --max_old_space_size=4095
[XX:XX:XX] Node flags detected: --max_old_space_size=4095
[XX:XX:XX] Using gulpfile /vscode/gulpfile.js
Done in ?s.
[XX:XX:XX] Error: /vscode/extensions/typescript-language-features/src/features/semanticTokens.ts(179,65): 'Proto' cannot be used as a value because it was imported using 'import type'.
[XX:XX:XX] Error: /vscode/extensions/typescript-language-features/src/features/semanticTokens.ts(186,69): 'Proto' cannot be used as a value because it was imported using 'import type'.
[XX:XX:XX] Error: /vscode/extensions/typescript-language-features/src/features/semanticTokens.ts(235,66): 'Proto' cannot be used as a value because it was imported using 'import type'.
[XX:XX:XX] Error: /vscode/extensions/typescript-language-features/src/protocol.d.ts(13,3): Duplicate identifier 'PrepareCallHierarchy'.
[XX:XX:XX] Error: /vscode/extensions/typescript-language-features/src/protocol.d.ts(14,3): Duplicate identifier 'ProvideCallHierarchyIncomingCalls'.
[XX:XX:XX] Error: /vscode/extensions/typescript-language-features/src/protocol.d.ts(15,3): Duplicate identifier 'ProvideCallHierarchyOutgoingCalls'.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.



Standard error:
[XX:XX:XX] 'compile' errored after
[XX:XX:XX] Error: Found 6 errors
at Stream.<anonymous> (/vscode/build/lib/reporter.js:74:29)
at _end (/vscode/node_modules/through/index.js:65:9)
at Stream.stream.end (/vscode/node_modules/through/index.js:74:5)
at StreamFilter.onend (/vscode/node_modules/readable-stream/lib/_stream_readable.js:570:10)
at Object.onceWrapper (events.js:286:20)
at StreamFilter.emit (events.js:203:15)
at StreamFilter.EventEmitter.emit (domain.js:466:23)
at endReadableNT (/vscode/node_modules/readable-stream/lib/_stream_readable.js:992:12)
at process._tickCallback (internal/process/next_tick.js:63:19)
error Command failed with exit code 1.
1 change: 1 addition & 0 deletions tests/baselines/reference/user/chrome-devtools-frontend.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -680,6 +680,7 @@ node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighth
Type 'number' is not assignable to type 'void'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(19744,7): error TS2339: Property 'expected' does not exist on type 'Error'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(20005,8): error TS2339: Property 'runLighthouseForConnection' does not exist on type 'Window & typeof globalThis'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(20015,15): error TS2554: Expected 0 arguments, but got 1.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(20035,8): error TS2339: Property 'runLighthouseInWorker' does not exist on type 'Window & typeof globalThis'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(20039,15): error TS2339: Property 'runLighthouseForConnection' does not exist on type 'Window & typeof globalThis'.
node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(20046,8): error TS2339: Property 'getDefaultCategories' does not exist on type 'Window & typeof globalThis'.
Expand Down
27 changes: 15 additions & 12 deletions tests/baselines/reference/user/follow-redirects.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,21 @@
Exit Code: 1
Standard output:
node_modules/follow-redirects/index.js(82,10): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(83,10): error TS2339: Property 'abort' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(130,10): error TS2339: Property 'once' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(133,12): error TS2339: Property 'socket' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(143,8): error TS2339: Property 'once' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(144,8): error TS2339: Property 'once' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(214,10): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(253,16): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(303,12): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(337,35): error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
node_modules/follow-redirects/index.js(96,10): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(97,10): error TS2339: Property 'abort' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(144,10): error TS2339: Property 'once' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(147,12): error TS2339: Property 'socket' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(157,8): error TS2339: Property 'once' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(158,8): error TS2339: Property 'once' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(228,10): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(267,16): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(317,12): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(343,35): error TS2345: Argument of type 'string | undefined' is not assignable to parameter of type 'string'.
Type 'undefined' is not assignable to type 'string'.
node_modules/follow-redirects/index.js(345,14): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(357,10): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(354,14): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(366,13): error TS2339: Property 'cause' does not exist on type 'CustomError'.
node_modules/follow-redirects/index.js(367,12): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(374,10): error TS2339: Property 'emit' does not exist on type 'RedirectableRequest'.
node_modules/follow-redirects/index.js(483,25): error TS2339: Property 'code' does not exist on type 'Error'.



Expand Down
29 changes: 15 additions & 14 deletions tests/baselines/reference/user/puppeteer.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ lib/Coverage.js(208,15): error TS2503: Cannot find namespace 'Protocol'.
lib/EmulationManager.js(36,16): error TS2503: Cannot find namespace 'Protocol'.
lib/ExecutionContext.js(26,15): error TS2503: Cannot find namespace 'Protocol'.
lib/ExecutionContext.js(158,18): error TS2503: Cannot find namespace 'Protocol'.
lib/ExecutionContext.js(186,14): error TS2503: Cannot find namespace 'Protocol'.
lib/FrameManager.js(151,15): error TS2503: Cannot find namespace 'Protocol'.
lib/FrameManager.js(173,15): error TS2503: Cannot find namespace 'Protocol'.
lib/FrameManager.js(230,15): error TS2503: Cannot find namespace 'Protocol'.
Expand All @@ -42,7 +43,7 @@ lib/NetworkManager.js(295,15): error TS2503: Cannot find namespace 'Protocol'.
lib/NetworkManager.js(319,15): error TS2503: Cannot find namespace 'Protocol'.
lib/NetworkManager.js(529,15): error TS2503: Cannot find namespace 'Protocol'.
lib/NetworkManager.js(668,15): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(94,33): error TS2345: Argument of type 'CDPSession' is not assignable to parameter of type 'Puppeteer.CDPSession'.
lib/Page.js(93,33): error TS2345: Argument of type 'CDPSession' is not assignable to parameter of type 'Puppeteer.CDPSession'.
Types of property 'on' are incompatible.
Type '(event: string | symbol, listener: (...args: any[]) => void) => CDPSession' is not assignable to type '<T extends string | number | symbol>(event: T, listener: (arg: any) => void) => CDPSession'.
Types of parameters 'event' and 'event' are incompatible.
Expand All @@ -52,20 +53,20 @@ lib/Page.js(94,33): error TS2345: Argument of type 'CDPSession' is not assignabl
Type 'T' is not assignable to type 'symbol'.
Type 'string | number | symbol' is not assignable to type 'symbol'.
Type 'string' is not assignable to type 'symbol'.
lib/Page.js(147,15): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(220,15): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(388,20): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(451,7): error TS2740: Type '(...args: any[]) => Promise<any>' is missing the following properties from type 'Window': applicationCache, clientInformation, closed, customElements, and 222 more.
lib/Page.js(461,9): error TS2349: This expression is not callable.
lib/Page.js(143,15): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(215,15): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(383,20): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(446,7): error TS2740: Type '(...args: any[]) => Promise<any>' is missing the following properties from type 'Window': applicationCache, clientInformation, closed, customElements, and 222 more.
lib/Page.js(456,9): error TS2349: This expression is not callable.
Type 'Window' has no call signatures.
lib/Page.js(497,15): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(507,22): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(520,15): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(530,15): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(555,15): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(608,14): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(944,19): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(1354,15): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(492,15): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(502,22): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(515,15): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(525,15): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(550,15): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(603,14): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(939,19): error TS2503: Cannot find namespace 'Protocol'.
lib/Page.js(1350,15): error TS2503: Cannot find namespace 'Protocol'.
lib/Target.js(23,15): error TS2503: Cannot find namespace 'Protocol'.
lib/Target.js(87,7): error TS2322: Type 'Promise<Worker | Worker>' is not assignable to type 'Promise<Worker>'.
Type 'Worker | Worker' is not assignable to type 'Worker'.
Expand Down
12 changes: 11 additions & 1 deletion tests/baselines/reference/user/sift.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,16 @@
Exit Code: 1
Standard output:
node_modules/sift/index.d.ts(80,15): error TS2307: Cannot find module './core'.
node_modules/sift/lib/core.d.ts(14,5): error TS2411: Property '$elemMatch' of type 'Query | undefined' is not assignable to string index type 'Object | Query'.
node_modules/sift/lib/core.d.ts(15,5): error TS2411: Property '$lt' of type 'number | undefined' is not assignable to string index type 'Object | Query'.
node_modules/sift/lib/core.d.ts(16,5): error TS2411: Property '$gt' of type 'number | undefined' is not assignable to string index type 'Object | Query'.
node_modules/sift/lib/core.d.ts(17,5): error TS2411: Property '$lte' of type 'number | undefined' is not assignable to string index type 'Object | Query'.
node_modules/sift/lib/core.d.ts(18,5): error TS2411: Property '$gte' of type 'number | undefined' is not assignable to string index type 'Object | Query'.
node_modules/sift/lib/core.d.ts(19,5): error TS2411: Property '$mod' of type '[number, number] | undefined' is not assignable to string index type 'Object | Query'.
node_modules/sift/lib/core.d.ts(20,5): error TS2411: Property '$exists' of type 'boolean | undefined' is not assignable to string index type 'Object | Query'.
node_modules/sift/lib/core.d.ts(21,5): error TS2411: Property '$regex' of type 'string | undefined' is not assignable to string index type 'Object | Query'.
node_modules/sift/lib/core.d.ts(22,5): error TS2411: Property '$options' of type '"i" | "u" | "g" | "m" | undefined' is not assignable to string index type 'Object | Query'.
node_modules/sift/lib/core.d.ts(24,5): error TS2411: Property '$or' of type 'Query[] | undefined' is not assignable to string index type 'Object | Query'.
node_modules/sift/lib/core.d.ts(25,5): error TS2411: Property '$nor' of type 'Query[] | undefined' is not assignable to string index type 'Object | Query'.



Expand Down
3 changes: 3 additions & 0 deletions tests/baselines/reference/user/webpack.log
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@ lib/ContextModule.js(465,34): error TS2341: Property 'moduleGraph' is private an
lib/ContextModule.js(767,34): error TS2341: Property 'moduleGraph' is private and only accessible within class 'ChunkGraph'.
lib/Dependency.js(139,29): error TS2341: Property 'moduleGraph' is private and only accessible within class 'ChunkGraph'.
lib/ExternalModule.js(284,54): error TS2341: Property 'moduleGraph' is private and only accessible within class 'ChunkGraph'.
lib/FileSystemInfo.js(357,4): error TS2345: Argument of type '({ type, context, path, expected }: { type: any; context: any; path: any; expected: any; }, callback: any) => void' is not assignable to parameter of type 'AsyncFunction<{ type: number; path: string; context?: string; expected?: string; }, Error>'.
Copy link
Member

@weswigham weswigham Jan 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahejlsberg this one's new to your PR, from what I can tell?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's new and it appears to be correct. According to the type annotations, the queue method expects an argument of type AsyncFunction<T, E> which is equivalent to (callback: (err?: E, result?: T) => void) => void. But the arrow function provided expects an object in the first parameter. Pretty sure the type annotations are wrong somehow, but certainly we're correct to report an error.

Types of parameters '__0' and 'callback' are incompatible.
Type '(err?: Error, result?: { type: number; path: string; context?: string; expected?: string; }) => void' is missing the following properties from type '{ type: any; context: any; path: any; expected: any; }': type, context, path, expected
lib/Module.js(625,34): error TS2341: Property 'moduleGraph' is private and only accessible within class 'ChunkGraph'.
lib/MultiCompiler.js(15,65): error TS2300: Duplicate identifier 'AsyncSeriesHook'.
lib/MultiCompiler.js(16,77): error TS2300: Duplicate identifier 'SyncBailHook'.
Expand Down