Treat write-only-access to a class member with setter as a reference. #35922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@weswigham the reviewers box is broken, but can you take a look at this too? |
weswigham
approved these changes
Mar 10, 2020
Member
weswigham
left a comment
weswigham
left a comment
There was a problem hiding this comment.
Looks reasonable to me - assuming setters exist to do something side-effecty seems reasonable.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #25476, writing to class member might have side-effect to other variable.
This PR treats write-only-access to a class member with setter as a reference, so
noUnusedLocalswarning won't appear on it.This PR wouldn't change the accessKind of
BinaryExpression,PrefixUnaryExpression, etc, which means "+= on private property" will still be treated asWriteOnlyAccessnotReadWriteAccess.Fixes #25476