Fixed issue with unreported error on missing method call in if test. #35862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanCavanaugh
requested changes
Jan 24, 2020
…get symbol did no have an id assigned or if the called property was used inside the if block on a different target.
dragomirtitian
force-pushed
the
GH-35557
branch
from
65134a7 to
d91ffc1
Compare
sandersn
approved these changes
Mar 30, 2020
Member
|
This is a pretty old commit, so merging will probably break the build. On the other hand, I can't fetch commits from dragomirtitian/TypeScript. So I'm going to merge and immediately build locally and push any fixes to master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue where missing method call went unreported if the call target symbol did no have an id assigned or if the called property was used inside the if block on a different target.
Fixes #35557