Revert microsoft/TypeScript#33171 #35751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahejlsberg
approved these changes
Dec 18, 2019
|
@orta @RyanCavanaugh We should get this one merged for 3.8. |
|
Ah, my bad, I never got back to hit the merge button - just rebased, will merge on green |
|
@orta Looks like the (now orphaned) error message didn't get deleted. We should fix that. |
orta
added a commit
to orta/TypeScript
that referenced
this pull request
Jan 21, 2020
orta
pushed a commit
that referenced
this pull request
Jan 21, 2020
|
Removed the error message - thanks #36332 |
Kingwl
pushed a commit
to Kingwl/TypeScript
that referenced
this pull request
Mar 4, 2020
…function that returns a union with undefined (microsoft#33171)" (microsoft#35751) This reverts commit be960fa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #33171 which should fix #35683