Skip to content

Make no inferences from binding patterns with no defaults #35454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 5, 2019
Merged

Make no inferences from binding patterns with no defaults #35454

merged 3 commits into from
Dec 5, 2019

Conversation

ahejlsberg
Copy link
Member

@ahejlsberg ahejlsberg commented Dec 2, 2019 •
edited
Loading

Fixes #30379.
Fixes #35291.

@ahejlsberg
Copy link
Member Author

@typescript-bot run dt
@typescript bot test this
@typescript bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Dec 3, 2019 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 0f7479b. You can monitor the build here. It should now contribute to this PR's status checks.

@ahejlsberg
Copy link
Member Author

@typescript-bot test this
@typescript-bot user test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Dec 3, 2019 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at 0f7479b. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Dec 3, 2019 •
edited
Loading

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 0f7479b. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot typescript-bot mentioned this pull request Dec 3, 2019
Closed
@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@ahejlsberg
Copy link
Member Author

Tests are clean. Community test failures look to be preexisting conditions.

@ahejlsberg ahejlsberg merged commit 09271f1 into master Dec 5, 2019
@jakebailey jakebailey deleted the fix35291 branch November 7, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generic uses any instead of the default one when deconstructing an array Type information lost when destructuring a function result tuple
3 participants
@ahejlsberg @typescript-bot @weswigham