Skip to content

Actually use the more complete update function in visitEachChild #35301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2019
Merged

Actually use the more complete update function in visitEachChild #35301

merged 1 commit into from
Nov 22, 2019

Conversation

weswigham
Copy link
Member

@weswigham weswigham commented Nov 22, 2019 •
edited
Loading

#35270 was slightly incomplete - it made individual update functions work, but because I forgot to update visitEachChild, the assignment assertion token would fail to percolate up a transformed tree.

@weswigham weswigham requested a review from rbuckton November 22, 2019 22:10
@weswigham weswigham merged commit 3e32946 into microsoft:master Nov 22, 2019
@weswigham weswigham deleted the fix-transform-assignment-assertions-more branch November 22, 2019 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbuckton rbuckton Awaiting requested review from rbuckton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@weswigham