Skip to content

Add fp-ts to user tests #35249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Add fp-ts to user tests #35249

merged 1 commit into from
Nov 22, 2019

Conversation

sandersn
Copy link
Member

This will let us test the up-to-date fp-ts instead of manually updating it approximately never.

I think just test.json is enough since it provides its own tsconfig.

@sandersn
Copy link
Member Author

@typescript-bot user test this

@sandersn sandersn requested a review from ahejlsberg November 20, 2019 23:00
@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 20, 2019

Heya @sandersn, I've started to run the parallelized community code test suite on this PR at c059252. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@sandersn
Copy link
Member Author

So...no diff from fp-ts, but none is expected since it passes. Run locally, I see "1 passing (40s)" from gulp runtests --ru=user --t=fp-ts

@sandersn sandersn merged commit 0234889 into master Nov 22, 2019
@sandersn sandersn deleted the add-fp-ts-to-user-tests branch November 22, 2019 00:07
@jablko jablko mentioned this pull request Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants