Fix 33436 #35225
Merged
Fix 33436 #35225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jack-williams
commented
Nov 20, 2019
jack-williams
force-pushed
the
fix33436
branch
from
b0ab212 to
5319858
Compare
tests/baselines/reference/assignmentCompatWithCallSignatures3.errors.txt
Outdated
Show resolved
Hide resolved
jack-williams
force-pushed
the
fix33436
branch
from
5319858 to
69a5e19
Compare
jack-williams
force-pushed
the
fix33436
branch
from
65a409f to
0d91997
Compare
|
Sorry @DanielRosenwasser, a bad merge flipped the elaboration arguments back. Fixed now. |
|
@weswigham the reviewers box is broken, but can you look at this too? |
weswigham
approved these changes
Mar 10, 2020
There was a problem hiding this comment.
The new error looks fine to me (assuming @DanielRosenwasser is still fine with this copy), but this is probably going to need a sync with master and re-baseline-update to not break the build on merge (as there's probably newer tests which'll get the new elaboration).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33436
Adds new error elaboration when relating to a type parameter and the source is not related to the constraint, or if a constraint does not exist.