🤖 User test baselines have changed for refs/heads/master #35218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
typescript-bot
force-pushed
the
user-update-Microsoft-20191003-refs/heads/master
branch
2 times, most recently
from
350292e to
4ca6c68
Compare
typescript-bot
force-pushed
the
user-update-Microsoft-20191003-refs/heads/master
branch
from
4ca6c68 to
2de9292
Compare
sandersn
approved these changes
Nov 20, 2019
| Standard output: | ||
| yarn run vX.X.X | ||
| $ gulp compile --max_old_space_size=4095 | ||
| [XX:XX:XX] Node flags detected: --max_old_space_size=4095 | ||
| [XX:XX:XX] Using gulpfile /vscode/gulpfile.js | ||
| Done in ?s. | ||
| [XX:XX:XX] Error: /vscode/src/vs/workbench/contrib/codeEditor/browser/suggestEnabledInput/suggestEnabledInput.ts(229,3): Type 'string | null' is not assignable to type 'string'. |
There was a problem hiding this comment.
@mjbvz this is a DOM change that will happen in 3.8. Can you pass this on the correct people? https://github.com/microsoft/TypeScript/pull/35207/files gives diff -- a number of properties now have type string instead of string | null.
| Type 'undefined' is not assignable to type 'string'. | ||
| lib/adapters/http.js(124,17): error TS2532: Object is possibly 'undefined'. | ||
| lib/adapters/http.js(124,40): error TS2532: Object is possibly 'undefined'. | ||
| lib/adapters/http.js(84,22): error TS2345: Argument of type 'string | null' is not assignable to parameter of type 'string'. |
There was a problem hiding this comment.
looks like an update to @types/node
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @microsoft/typescript