Skip to content

Create returnOnlySignature only when inferences will possibly be made #35173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 25, 2019
Merged

Create returnOnlySignature only when inferences will possibly be made #35173

merged 3 commits into from
Nov 25, 2019

Conversation

ahejlsberg
Copy link
Member

Fixes #34849.

@ahejlsberg
Copy link
Member Author

@typescript-bot test this
@typescript-bot user test this
@typescript-bot run dt

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 18, 2019 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized Definitely Typed test suite on this PR at 6a93ed9. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 18, 2019 •
edited
Loading

Heya @ahejlsberg, I've started to run the extended test suite on this PR at 6a93ed9. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot
Copy link
Collaborator

typescript-bot commented Nov 18, 2019 •
edited
Loading

Heya @ahejlsberg, I've started to run the parallelized community code test suite on this PR at 6a93ed9. You can monitor the build here. It should now contribute to this PR's status checks.

@typescript-bot typescript-bot mentioned this pull request Nov 18, 2019
Closed
@typescript-bot
Copy link
Collaborator

The user suite test run you requested has finished and failed. I've opened a PR with the baseline diff from master.

@ahejlsberg
Copy link
Member Author

Tests look good (failures in DT and Community Tests are preexisting conditions).

@weswigham
Copy link
Member

Reminder: this change needs a test case added.

@ahejlsberg ahejlsberg merged commit 0c2c58c into master Nov 25, 2019
@ahejlsberg ahejlsberg deleted the fix34849 branch November 25, 2019 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weswigham weswigham weswigham approved these changes

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generic inference different between equivalent function expression and shorthand method in object literal (vol 2)
3 participants
@ahejlsberg @typescript-bot @weswigham