🤖 User test baselines have changed for refs/heads/master #35075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
typescript-bot
force-pushed
the
user-update-Microsoft-20191003-refs/heads/master
branch
from
1919f10 to
d7bb06d
Compare
typescript-bot
force-pushed
the
user-update-Microsoft-20191003-refs/heads/master
branch
from
d7bb06d to
e05d19b
Compare
weswigham
approved these changes
Nov 13, 2019
sandersn
reviewed
Nov 13, 2019
| node_modules/@typescript-eslint/typescript-estree/dist/create-program/createWatchProgram.d.ts(1,8): error TS1259: Module '"/prettier/prettier/node_modules/typescript/lib/typescript"' can only be default-imported using the 'esModuleInterop' flag | ||
| src/cli/util.js(60,44): error TS2345: Argument of type 'null' is not assignable to parameter of type 'number | undefined'. | ||
| src/cli/util.js(119,38): error TS2339: Property 'sync' does not exist on type '(...args: any[]) => any'. | ||
| src/cli/util.js(413,36): error TS2345: Argument of type '{ dot: true; nodir: boolean; }' is not assignable to parameter of type 'GlobbyOptions'. |
There was a problem hiding this comment.
this error seems like it should not have disappeared.
| src/cli/util.js(413,36): error TS2345: Argument of type '{ dot: true; nodir: boolean; }' is not assignable to parameter of type 'GlobbyOptions'. | ||
| Object literal may only specify known properties, and 'nodir' does not exist in type 'GlobbyOptions'. | ||
| src/cli/util.js(507,44): error TS2345: Argument of type 'null' is not assignable to parameter of type 'number | undefined'. | ||
| src/cli/util.js(528,37): error TS2339: Property 'grey' does not exist on type 'typeof import("/prettier/prettier/node_modules/chalk/types/index")'. |
There was a problem hiding this comment.
completions work but there is no error and the type is any.
| Object literal may only specify known properties, and 'nodir' does not exist in type 'GlobbyOptions'. | ||
| src/cli/util.js(507,44): error TS2345: Argument of type 'null' is not assignable to parameter of type 'number | undefined'. | ||
| src/cli/util.js(528,37): error TS2339: Property 'grey' does not exist on type 'typeof import("/prettier/prettier/node_modules/chalk/types/index")'. | ||
| src/cli/util.js(591,16): error TS2339: Property 'type' does not exist on type 'never'. |
There was a problem hiding this comment.
in option.type, option: any but should be option: never
|
Yes, ha ha, prettier DOES want to compile using Typescript: e50ad942b |
|
So anyway, the commit is prettier/prettier@e50ad942b. It is annoying that we are not checking as much of prettier as before, but the intent of this test suite is to make sure important customers don't break on the nightly, so I think it's fine to only see breaks that prettier devs would see. I'm sure they'll reduce the size of their exclude list over time anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test run was triggerd by a request on #33716
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @microsoft/typescript