Skip to content

Adds 'did you mean' to the CLI args parser #35063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 14, 2019
Merged

Conversation

orta
Copy link
Contributor

@orta orta commented Nov 12, 2019

Catches some of the cases where casing or an "s" is missing in our config options:

node tsc.js index.js --allowJs  --declarations --sdsffs
error TS5025: Unknown compiler option '--declarations'. Did you mean 'declaration'?
error TS5023: Unknown compiler option '--sdsffs'.

@orta orta requested a review from sheetalkamat November 12, 2019 20:10
@orta orta force-pushed the did_you_mean_cli branch 2 times, most recently from 190f48b to 9a4ad52 Compare November 13, 2019 21:08
@orta
Copy link
Contributor Author

orta commented Nov 13, 2019

OK, I'm now like 95% on my certainty that this is good 🍡 and correctly handles tsconfig values

Screen Shot 2019-11-13 at 4 00 09 PM

@orta orta merged commit ef0cca7 into microsoft:master Nov 14, 2019
@orta
Copy link
Contributor Author

orta commented Nov 14, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants